fix: Default no module manager found to state Ready (#1853)

kyma-project · Sep 10, 2024 · 8474607 · 8474607
1 parent 2ad71dd
commit 8474607
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/internal/manifest/statecheck/state_check.go b/internal/manifest/statecheck/state_check.go
@@ -60,7 +60,7 @@ func (m *ManagerStateCheck) GetState(ctx context.Context,
 ) (shared.State, error) {
 	mgr := findManager(clnt, resources)
 	if mgr == nil {
-		return shared.StateError, ErrNoManagerProvided
+		return shared.StateReady, nil
 	}
 
 	switch mgr.kind {
@@ -71,7 +71,7 @@ func (m *ManagerStateCheck) GetState(ctx context.Context,
 	}
 
 	// fall through that should not be reached
-	return shared.StateError, ErrNoStateDetermined
+	return shared.StateReady, nil
 }
 
 func findManager(clt client.Client, resources []*resource.Info) *Manager {

diff --git a/internal/manifest/statecheck/state_check_test.go b/internal/manifest/statecheck/state_check_test.go
@@ -55,7 +55,7 @@ func TestManagerStateCheck_GetState(t *testing.T) {
 			resources:     []*resource.Info{},
 			isDeployment:  false,
 			isStateFulSet: false,
-			expectedError: statecheck.ErrNoManagerProvided,
+			expectedError: nil,
 		},
 	}
 	for _, testCase := range tests {