Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce metrics to track each Module Manifest reconcile performance #1069

Closed
2 tasks done
ruanxin opened this issue Nov 20, 2023 · 0 comments · Fixed by #1321, #1374 or #1380
Closed
2 tasks done

Introduce metrics to track each Module Manifest reconcile performance #1069

ruanxin opened this issue Nov 20, 2023 · 0 comments · Fixed by #1321, #1374 or #1380
Assignees
Labels
area/monitoring Issues or PRs related to the monitoring module (deprecated)
Milestone

Comments

@ruanxin
Copy link
Contributor

ruanxin commented Nov 20, 2023

Description:

At the moment, LM has the internal implemented performance metrics for manifest CR reconcile, however, it lacks of detailed view to tell how is each Module individually performed, which makes the troubleshooting difficult if some problematic modules are introduced.

AC Updates

  • Introduce Gauge metrics reconcile_duration_seconds with Manifest name as label to track each Manifest success reconciliation duration time

    • configure a duration threshold value (1mins), only add new metric above the threshold, also take care to delete existing metrics if duration time is lower than the threshold.
  • Add a new metric diagram in the Plutono dashboard.

@janmedrek janmedrek added the area/monitoring Issues or PRs related to the monitoring module (deprecated) label Jan 15, 2024
@LeelaChacha LeelaChacha self-assigned this Feb 13, 2024
@LeelaChacha LeelaChacha removed their assignment Feb 17, 2024
@nesmabadr nesmabadr reopened this Mar 4, 2024
LeelaChacha added a commit to LeelaChacha/kyma-lifecycle-manager that referenced this issue Mar 4, 2024
@nesmabadr nesmabadr assigned nesmabadr and unassigned nesmabadr Mar 5, 2024
@nesmabadr nesmabadr removed their assignment Mar 7, 2024
@nesmabadr nesmabadr reopened this Mar 8, 2024
@nesmabadr nesmabadr assigned nesmabadr and unassigned c-pius and nesmabadr Mar 8, 2024
@c-pius c-pius assigned nesmabadr and unassigned c-pius Mar 14, 2024
@janmedrek janmedrek modified the milestones: 0.1.2, 0.1.1 Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment