Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix manual E2E workflow dispatch with k8s version #2042

Closed
1 task
lindnerby opened this issue Nov 21, 2024 · 1 comment · Fixed by #2066 or #2072
Closed
1 task

Fix manual E2E workflow dispatch with k8s version #2042

lindnerby opened this issue Nov 21, 2024 · 1 comment · Fixed by #2066 or #2072
Assignees
@LeelaChacha
Labels
area/quality Related to all activites around quality kind/bug Categorizes issue or PR as related to a bug. kind/chore Categorizes issue or PR as related to a chore.

Comments

@lindnerby
Copy link
Member

lindnerby commented Nov 21, 2024 •
edited by janmedrek
Loading

Description

The E2E test suite can not be run at the moment with a specific Kubernetes version set as manual workflow dispatch in Github Actions. Investigate why the pipeline is failing and fix it.
Testing with version 1.31 lead to failure.

Reasons

No response

Acceptance Criteria

Feature Testing

No response

Testing approach

No response

Attachments

Example run: https://github.com/kyma-project/lifecycle-manager/actions/runs/11933648805
@lindnerby lindnerby added kind/feature Categorizes issue or PR as related to a new feature. kind/bug Categorizes issue or PR as related to a bug. kind/chore Categorizes issue or PR as related to a chore. area/quality Related to all activites around quality and removed kind/feature Categorizes issue or PR as related to a new feature. labels Nov 21, 2024
@c-pius
Copy link
Contributor

c-pius commented Nov 25, 2024

https://github.com/kyma-project/lifecycle-manager/blob/ac820ab30dfe38a04873959dff1fdb93f9248aa4/.github/workflows/test-e2e.yml#L27C84-L27C118

uses github.event.pull_request.head.sha which is likely not available on manual dispatch.

@LeelaChacha LeelaChacha self-assigned this Nov 27, 2024
@LeelaChacha LeelaChacha mentioned this issue Nov 27, 2024
Merged
LeelaChacha added a commit to LeelaChacha/kyma-lifecycle-manager that referenced this issue Nov 27, 2024
@LeelaChacha
Merge branch 'main' into feature/kyma-project#2042-fix-manual-e2e-wor…
dcedb3b 
…kflow
@LeelaChacha LeelaChacha removed their assignment Nov 27, 2024
@lindnerby lindnerby reopened this Nov 28, 2024
@LeelaChacha LeelaChacha mentioned this issue Nov 28, 2024
Merged
LeelaChacha added a commit to LeelaChacha/kyma-lifecycle-manager that referenced this issue Nov 28, 2024
@LeelaChacha
Merge branch 'main' into feature/kyma-project#2042-new-fix-e2e-manual…
d499a19 
…-worklfow
LeelaChacha added a commit to LeelaChacha/kyma-lifecycle-manager that referenced this issue Nov 29, 2024
@LeelaChacha
Merge branch 'main' into feature/kyma-project#2042-new-fix-e2e-manual…
7553acd 
…-worklfow
@lindnerby lindnerby assigned lindnerby and unassigned LeelaChacha Dec 2, 2024
lindnerby added a commit to LeelaChacha/kyma-lifecycle-manager that referenced this issue Dec 3, 2024
@lindnerby
Merge branch 'main' into feature/kyma-project#2042-new-fix-e2e-manual…
1adcc0b 
…-worklfow
LeelaChacha added a commit to LeelaChacha/kyma-lifecycle-manager that referenced this issue Dec 4, 2024
@LeelaChacha
Merge branch 'main' into feature/kyma-project#2042-new-fix-e2e-manual…
13b183f 
…-worklfow
@lindnerby lindnerby assigned LeelaChacha and unassigned lindnerby Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeelaChacha LeelaChacha

Labels
area/quality Related to all activites around quality kind/bug Categorizes issue or PR as related to a bug. kind/chore Categorizes issue or PR as related to a chore.
Projects
None yet
Milestone
No milestone
3 participants
@c-pius @lindnerby @LeelaChacha