Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module Catalog] Fetch Mandatory ModuleTemplate which has the highest version #2068

Closed
4 tasks done
nesmabadr opened this issue Nov 28, 2024 · 1 comment · Fixed by #2123
Closed
4 tasks done

[Module Catalog] Fetch Mandatory ModuleTemplate which has the highest version #2068

nesmabadr opened this issue Nov 28, 2024 · 1 comment · Fixed by #2123
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@nesmabadr
Copy link
Contributor

nesmabadr commented Nov 28, 2024

Description

We agreed to have the name of the mandatory ModuleTemplates the same format as that of the regular ModuleTemplates modulename-version. So we need to handle the case when there are multiple ModuleTemplates for the same Mandatory Module by using the ModuleTemplate with the highest version.

Reasons

No response

Acceptance Criteria

  • Add the logic to fetch the ModuleTemplate with highest version for mandatory modules.
  • Add an E2E test scenario with two ModuleTemplates with different versions for a mandatory module. (Validate its installation as well as its deletion).
  • Add documentation that for mandatory modules, KLM will install the module template with the highest version in case there are multiple
  • Follow-up on informing neighbors that modulectl can now also be used for mandatory modules

Feature Testing

Integration tests, End-to-End tests, Unit tests

Testing approach

No response

Attachments

No response

@nesmabadr nesmabadr added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 28, 2024
@nesmabadr nesmabadr changed the title [Module Catalog] Fetch Mandatory ModuleTemplate which has the latest version [Module Catalog] Fetch Mandatory ModuleTemplate which has the highest version Nov 28, 2024
@nesmabadr nesmabadr self-assigned this Dec 12, 2024
@nesmabadr nesmabadr removed their assignment Dec 17, 2024
@c-pius c-pius assigned nesmabadr and unassigned c-pius Dec 18, 2024
@c-pius
Copy link
Contributor

c-pius commented Jan 14, 2025

Still needs canary verification, but verification blocked by #2177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
2 participants