Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle Mandatory ModuleTemplates with the new ModuleTemplate naming #2123

Merged

Conversation

nesmabadr
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Adjust mandatory module template lookup to fetch the latest version
  • Adapt tests

Related issue(s)
Resolves #2068

@nesmabadr nesmabadr added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 13, 2024
@nesmabadr nesmabadr force-pushed the mandatorymodules_multipleversion branch from 4c23895 to e961bd9 Compare December 13, 2024 14:26
@nesmabadr nesmabadr force-pushed the mandatorymodules_multipleversion branch from efeac16 to 536de4d Compare December 13, 2024 14:59
@nesmabadr nesmabadr force-pushed the mandatorymodules_multipleversion branch from 96d844d to 7080032 Compare December 13, 2024 15:30
@nesmabadr nesmabadr force-pushed the mandatorymodules_multipleversion branch from 365e32a to d3d247e Compare December 15, 2024 16:07
@nesmabadr nesmabadr force-pushed the mandatorymodules_multipleversion branch from d3d247e to b44bc9d Compare December 15, 2024 16:11
@nesmabadr nesmabadr force-pushed the mandatorymodules_multipleversion branch 6 times, most recently from 47d4d23 to b9e9f1e Compare December 16, 2024 10:01
@nesmabadr nesmabadr force-pushed the mandatorymodules_multipleversion branch 2 times, most recently from 7a0b303 to cc091b0 Compare December 16, 2024 17:24
@nesmabadr nesmabadr force-pushed the mandatorymodules_multipleversion branch from cc091b0 to 36fad1e Compare December 16, 2024 17:38
@nesmabadr nesmabadr marked this pull request as ready for review December 17, 2024 08:23
@nesmabadr nesmabadr requested review from a team as code owners December 17, 2024 08:23
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2024
docs/contributor/02-controllers.md Outdated Show resolved Hide resolved
pkg/templatelookup/mandatory.go Show resolved Hide resolved
pkg/templatelookup/mandatory.go Show resolved Hide resolved
pkg/templatelookup/mandatory.go Outdated Show resolved Hide resolved
pkg/templatelookup/mandatory_test.go Show resolved Hide resolved
pkg/templatelookup/mandatory_test.go Outdated Show resolved Hide resolved
tests/e2e/mandatory_module_test.go Show resolved Hide resolved
.github/actions/deploy-lifecycle-manager-e2e/action.yml Outdated Show resolved Hide resolved
@nesmabadr nesmabadr force-pushed the mandatorymodules_multipleversion branch from 22ffc15 to ffe957b Compare December 17, 2024 16:24
@nesmabadr nesmabadr requested a review from c-pius December 17, 2024 16:26
c-pius
c-pius previously approved these changes Dec 18, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 18, 2024
@c-pius c-pius mentioned this pull request Dec 18, 2024
4 tasks
Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Dec 18, 2024
@nesmabadr nesmabadr requested review from mmitoraj and c-pius December 18, 2024 08:18
@nesmabadr nesmabadr enabled auto-merge (squash) December 18, 2024 08:19
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 18, 2024
@nesmabadr nesmabadr merged commit 6ccede3 into kyma-project:main Dec 18, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Module Catalog] Fetch Mandatory ModuleTemplate which has the highest version
4 participants