Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance Windows] Read maintenance window policies #2163

Open
11 tasks
c-pius opened this issue Jan 7, 2025 · 2 comments · May be fixed by #2171
Open
11 tasks

[Maintenance Windows] Read maintenance window policies #2163

c-pius opened this issue Jan 7, 2025 · 2 comments · May be fixed by #2171
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@c-pius
Copy link
Contributor

c-pius commented Jan 7, 2025

Description

Split out of #2101

KLM needs to read the maintenance window policies. It was agreed that for now it is sufficient to read it on startup (no continuous watch on the policy). Until it is rolled out to production, the policy config map and volume mount are only added to the local test kustomization target. Therefore, KLM should not error out when not finding the policy file. Instead, it should work with an empty policy (no maintenance windows). With this, KLM should remain functional even without maintenance window policy config map mounted.

AC

  • kustomization for local setup
    • creates config map for a default maintenance window policy
    • mounts the config map
  • on startup, KLM reads the mounted file and resolves the maintenance window policy via the resolver module
    • read maintenance window policies cached
    • if the file is not found, it defaults to empty maintenance window policy (no maintenane windows)
  • existing e2e tests remain functional
  • new e2e test verifies that that the maintenance window policy can be read and resolved, and the default in case there is no file
  • unit tests verify the proper delegation of the maintenance window policy resolving via the resolver module
@c-pius c-pius added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 7, 2025
@c-pius
Copy link
Contributor Author

c-pius commented Jan 9, 2025

Note: the existing resolver library has not been tested extensively yet. We may run into problems here once we start reading some test data.

@c-pius
Copy link
Contributor Author

c-pius commented Jan 9, 2025

3 is an optimistic guess, may also be a 5.

@nesmabadr nesmabadr self-assigned this Jan 13, 2025
@nesmabadr nesmabadr linked a pull request Jan 13, 2025 that will close this issue
@nesmabadr nesmabadr removed their assignment Jan 15, 2025
@lindnerby lindnerby self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants