Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow different drop storage versions based on crd kind #1385

Merged
merged 6 commits into from
Mar 15, 2024
Merged

feat: Allow different drop storage versions based on crd kind #1385

merged 6 commits into from
Mar 15, 2024

Conversation

nesmabadr
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Allow different drop storage versions based on crd kind

Related issue(s)
Resolves #1383

@nesmabadr nesmabadr requested a review from a team as a code owner March 11, 2024 12:05
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 11, 2024
@nesmabadr nesmabadr added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2024
@nesmabadr nesmabadr force-pushed the drop_different_stored_versions branch from 9b8238f to 4fa2be4 Compare March 13, 2024 13:21
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 13, 2024
@nesmabadr nesmabadr force-pushed the drop_different_stored_versions branch from 4fa2be4 to d81cc27 Compare March 13, 2024 13:26
@nesmabadr nesmabadr removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2024
@nesmabadr nesmabadr force-pushed the drop_different_stored_versions branch 2 times, most recently from 41e1108 to 8c63852 Compare March 14, 2024 09:42
@nesmabadr nesmabadr force-pushed the drop_different_stored_versions branch from 8c63852 to cf80c9c Compare March 14, 2024 09:44
jeremyharisch
jeremyharisch reviewed Mar 15, 2024
View reviewed changes
Copy link
Contributor

@jeremyharisch jeremyharisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment to have more detail in the flag docs, otherwise looks good

@nesmabadr nesmabadr force-pushed the drop_different_stored_versions branch from 7c36b82 to 015298c Compare March 15, 2024 12:28
@nesmabadr nesmabadr requested a review from jeremyharisch March 15, 2024 12:29
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 15, 2024
@kyma-bot kyma-bot merged commit c974d85 into kyma-project:main Mar 15, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyharisch jeremyharisch jeremyharisch approved these changes

Assignees

@jeremyharisch jeremyharisch

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DropStoredVersion should support storage versions based on CRD kind
3 participants
@nesmabadr @jeremyharisch @kyma-bot