Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remote pkg & sync strategy label #1426

Merged
merged 69 commits into from
May 22, 2024
Merged

refactor: Remote pkg & sync strategy label #1426

merged 69 commits into from
May 22, 2024

Conversation

lindnerby
Copy link
Member

@lindnerby lindnerby commented Mar 26, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Remove client caching from context and replace skr context retrieval with explicit interface
  • Remove need for sync strategy annotation
  • Remove global var localClientFunc and function implementations to be replaced with context related interface implementations
  • Move remote pkg to internal

Related issue(s)

@lindnerby lindnerby requested review from a team as code owners March 26, 2024 06:58
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 26, 2024
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 9, 2024
@lindnerby lindnerby changed the title testing refactor: Remote pkg & sync strategy label Apr 18, 2024
ruanxin
ruanxin requested changes May 8, 2024
View reviewed changes
Copy link
Contributor

@ruanxin ruanxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just some suggestions I believe can make this refactoring more clean.

@lindnerby lindnerby force-pushed the skr-client-provider branch from 7156db5 to cd0122c Compare May 17, 2024 11:55
@lindnerby lindnerby requested a review from ruanxin May 21, 2024 07:30
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 22, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label May 22, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 22, 2024
@kyma-bot kyma-bot merged commit d51230b into kyma-project:main May 22, 2024
43 of 44 checks passed
@lindnerby lindnerby deleted the skr-client-provider branch May 23, 2024 06:25
@c-pius c-pius added the area/quality Related to all activites around quality label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitoraj mmitoraj mmitoraj approved these changes

@ruanxin ruanxin ruanxin approved these changes

Assignees

@ruanxin ruanxin

@mmitoraj mmitoraj

Labels
area/quality Related to all activites around quality cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactoring: Remove localClient global Variable in remote pkg
5 participants
@lindnerby @ruanxin @mmitoraj @c-pius @kyma-bot