Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove inapplicable kubebuiler:subresource:status markers #1432

Merged

Conversation

c-pius
Copy link
Contributor

@c-pius c-pius commented Mar 26, 2024

Description

Changes proposed in this pull request:

  • removes inapplicable kubebuiler:subresource:status markers from WatcherStatus and KymaStatus
    • kubebuilder assigns a clear meaning behind subresource:status (see here, and here)
    • the proper kubebuilder:subresource:status markers for Kyma and Watcher are here and here
    • applying them again on the XXXStatus struct seems unintended and does not yield any changes in the generated CRDs (re-ran make manifests and subresources field in generated CRD remain unchanged)

Related issue(s)

@c-pius c-pius requested a review from a team as a code owner March 26, 2024 15:08
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 26, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 27, 2024
@c-pius c-pius force-pushed the chore/remove-unused-status-subresource branch from 1398c4d to 322c447 Compare March 27, 2024 09:01
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Mar 27, 2024
@c-pius c-pius requested a review from nesmabadr March 27, 2024 09:01
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 27, 2024
@kyma-bot kyma-bot merged commit dfa88a9 into kyma-project:main Mar 27, 2024
44 checks passed
@c-pius c-pius deleted the chore/remove-unused-status-subresource branch April 17, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants