-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix local test setup scripts #1446
Conversation
556c8df
to
38915b2
Compare
38915b2
to
ec9ca66
Compare
ec9ca66
to
ef34f7a
Compare
# build your local image | ||
make docker-build IMG=k3d-registry.localhost:5111/<your-image-name>:<your-image-tag> | ||
# push it to the local registry | ||
make docker-push IMG=k3d-registry.localhost:5111/<your-image-name>:<your-image-tag> | ||
# deploy using the image (note the change to port 5000 which is exposed in the cluster) | ||
make local-deploy-with-watcher IMG=k3d-registry.localhost:5000/<your-image-name>:<your-image-tag> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment: I think we need to provide the registry and especially the port change for it to work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
cd <local path to template operator repository> | ||
|
||
# generates the manifests and saves them to a template-operator.yaml file | ||
make build-manifests | ||
|
||
# create the a ModuleTemplate CR and saves it to a template-yaml file | ||
kyma alpha create module -p ./ --version 1.2.3 \ | ||
--registry k3d-registry.localhost:5111 --insecure --module-config-file ./module-config.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment: at least on my machine I cannot just create the module specifying a path to the template operator repo. Therefore I changed this to cd into the needed directory.
E.g. (../template-operator
is my local way to the repo):
kyma alpha create module -p ../template-operator --version 1.2.3 \
--registry k3d-registry.localhost:5111 --insecure --module-config-file ../template-operator/module-config.yaml
CAUTION: You're using an outdated version of the Kyma CLI (2.20.1). The latest released version is: 2.20.3
WARNING: This command is experimental and might change in its final version. Use at your own risk.
- Module built (8ms)
- Default CR validation succeeded (9.595s)
- component descriptor created (1ms)
X Configuring security scanning... (5ms)
Error: component.resources.0: Must validate at least one schema (anyOf);component.resources.0.version: Does not match pattern '^[v]?(0|[1-9]\d*)(?:\.(0|[1-9]\d*))?(?:\.(0|[1-9]\d*))?(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
ef34f7a
to
17b8377
Compare
# generates the manifests and saves them to a template-operator.yaml file | ||
make build-manifests | ||
|
||
# create the a ModuleTemplate CR and saves it to a template-yaml file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# create the a ModuleTemplate CR and saves it to a template-yaml file | |
# create a ModuleTemplate CR and save it to a template YAML file |
In the previous set of comments, you used the second-person singular (user perspective), now third-person singular (command perspective), let's unify.
make local-deploy-with-watcher IMG=<image-name>:<image-tag> | ||
# build your local image | ||
make docker-build IMG=k3d-registry.localhost:5111/<your-image-name>:<your-image-tag> | ||
# push it to the local registry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# push it to the local registry | |
# push the image to the local registry |
make docker-build IMG=k3d-registry.localhost:5111/<your-image-name>:<your-image-tag> | ||
# push it to the local registry | ||
make docker-push IMG=k3d-registry.localhost:5111/<your-image-name>:<your-image-tag> | ||
# deploy using the image (note the change to port 5000 which is exposed in the cluster) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# deploy using the image (note the change to port 5000 which is exposed in the cluster) | |
# deploy Lifecycle Manager using the image (note the change to port 5000 which is exposed in the cluster) |
--registry k3d-registry.localhost:5111 --insecure --module-config-file ../template-operator/module-config.yaml | ||
cd <local path to template operator repository> | ||
|
||
# generates the manifests and saves them to a template-operator.yaml file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# generates the manifests and saves them to a template-operator.yaml file | |
# generate the manifests and save them to a template-operator.yaml file |
In the previous set of comments, you used the second-person singular (user perspective), now third-person singular (command perspective), let's unify.
17b8377
to
74a53ce
Compare
Description
Changes proposed in this pull request:
Related issue(s)