chore: Introduce shared GitHub Actions #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
do-not-merge/work-in-progress
c-pius
force-pushed
the
chore/shared-github-actions
branch
8 times, most recently
from
c91db95 to
c5c2559
Compare
kyma-bot
added
size/L
c-pius
force-pushed
the
chore/shared-github-actions
branch
12 times, most recently
from
22b0dd2 to
ef4b6e6
Compare
kyma-bot
added
size/XL
c-pius
force-pushed
the
chore/shared-github-actions
branch
from
f405232 to
e203069
Compare
c-pius
commented
Apr 10, 2024
Comment on lines
+24
to
+38
| steps: | ||
| - name: Define variables | ||
| id: define-variables | ||
| shell: bash | ||
| run: | | ||
| echo "k8s_version=${{ github.event.inputs.k8s_version || '1.28.7' }}" >> $GITHUB_OUTPUT | ||
| echo "istio_version=1.20.3" >> $GITHUB_OUTPUT | ||
| echo "k3d_version=5.6.0" >> $GITHUB_OUTPUT | ||
| echo "cert_manager_version=1.13.3" >> $GITHUB_OUTPUT | ||
| echo "klm_version_tag=PR-${{ github.event.pull_request.number }}" >> $GITHUB_OUTPUT | ||
| echo "klm_image_repo=dev" >> $GITHUB_OUTPUT | ||
| - name: Expose environment variables | ||
| shell: bash | ||
| run: | | ||
| echo "GOSUMDB=off" >> $GITHUB_ENV |
There was a problem hiding this comment.
comment: I opted to have everything just needed in the test setup as "regular" vars, and to only export those things as env vars which are needed downstream by the tests.
Comment on lines
+33
to
+34
| echo "klm_version_tag=PR-${{ github.event.pull_request.number }}" >> $GITHUB_OUTPUT | ||
| echo "klm_image_repo=dev" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
comment: these here used to be a conditional based on whether the job is running for a main build or a PR build. Since we removed the post main build, I removed this conditional now.
c-pius
force-pushed
the
chore/shared-github-actions
branch
from
80fcab5 to
a3a9cec
Compare
c-pius
removed
the
do-not-merge/hold
jeremyharisch
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Comments
To ease the review allowing to compare the new workflow runs against the old ones, the oldtest-e2e.yamlworkflow is still there unchanged and the new workflow is intest-e2e-junk.yaml. Once the changes are good to go, the old file will be updated with the new workflow and the separate junk file will be deleted.When reviewing, it is probably best to start fromtest-e2e-junk.yamland from there look into the used helper actions.Once this PR is merged, we can re-use the actions in watcher. Right now it is not possible because policies restrict using actions from forked repositories.