Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix permissions in DockerFile #1504

Merged
merged 8 commits into from
May 6, 2024
Merged

fix: Fix permissions in DockerFile #1504

merged 8 commits into from
May 6, 2024

Conversation

nesmabadr
Copy link
Contributor

@nesmabadr nesmabadr commented Apr 26, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Fix permissions in the Dockerfile in preparation for the migration to ADO pipeline
  • Rename workspace since it overrides files used by kaniko

Related issue(s)
https://github.com/orgs/kyma-project/projects/30/views/15?pane=issue&itemId=60682205

@nesmabadr nesmabadr requested a review from a team as a code owner April 26, 2024 11:08
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 26, 2024
@nesmabadr nesmabadr added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2024
@nesmabadr nesmabadr closed this Apr 26, 2024
@nesmabadr nesmabadr reopened this Apr 30, 2024
@nesmabadr nesmabadr force-pushed the test_prow_jobs branch 5 times, most recently from 98ae607 to 73d81b1 Compare April 30, 2024 16:54
@nesmabadr nesmabadr changed the title [Do NOT MERGE] test prow jobs WIP: Fix permissions in DockerFile Apr 30, 2024
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 2, 2024
@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 2, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 2, 2024
@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 2, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 2, 2024
@nesmabadr nesmabadr force-pushed the test_prow_jobs branch 4 times, most recently from 56c71c8 to f01d459 Compare May 2, 2024 12:12
@nesmabadr nesmabadr changed the title WIP: Fix permissions in DockerFile fix: Fix permissions in DockerFile May 2, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2024
@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 2, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 2, 2024
@nesmabadr nesmabadr removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 6, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label May 6, 2024
@nesmabadr nesmabadr requested a review from c-pius May 6, 2024 12:10
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 6, 2024
@kyma-bot kyma-bot merged commit d1ae7a8 into kyma-project:main May 6, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-pius c-pius c-pius approved these changes

Assignees

@c-pius c-pius

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nesmabadr @c-pius @kyma-bot