Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade controller-runtime version to v0.18.1 #1514

Conversation

Tomasz-Smelcerz-SAP
Copy link
Member

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP commented May 2, 2024

Description

controller-runtime in version v0.18.0 introduced some breaking changes to the event-related APIs.
This PR adjusts our code as necessary to work correctly with the upgraded controller-runtime.

Changes proposed in this pull request:

  • upgrade controller-runtime version to v0.18.1

Related issue(s)

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP requested a review from a team as a code owner May 2, 2024 13:53
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 2, 2024
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP force-pushed the chore/upgrade-controller-runtime branch from 4f2fbec to 3054f6c Compare May 2, 2024 14:26
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 2, 2024
@nesmabadr nesmabadr self-assigned this May 2, 2024
go.mod Show resolved Hide resolved
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 3, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 3, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label May 3, 2024
@nesmabadr nesmabadr self-requested a review May 3, 2024 10:22
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 3, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label May 3, 2024
@nesmabadr nesmabadr self-requested a review May 3, 2024 11:57
nesmabadr
nesmabadr previously approved these changes May 3, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 3, 2024
@nesmabadr
Copy link
Contributor

nesmabadr commented May 6, 2024

It seems that you need to run make manifests because a new change is there

@kyma-bot kyma-bot removed the lgtm Looks good to me! label May 6, 2024
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP added the confirm/helm-update The author explicitly confirms that a Helm update is not needed or is taken care of label May 8, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 8, 2024
@kyma-bot kyma-bot merged commit 402c5d2 into kyma-project:main May 8, 2024
41 checks passed
@nesmabadr nesmabadr linked an issue May 8, 2024 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. confirm/helm-update The author explicitly confirms that a Helm update is not needed or is taken care of lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump ocm from 0.8.0 to 0.9.0 and controller-runtime from 0.17.3 to 0.18.1
3 participants