-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade controller-runtime version to v0.18.1 #1514
Merged
kyma-bot
merged 9 commits into
kyma-project:main
from
Tomasz-Smelcerz-SAP:chore/upgrade-controller-runtime
May 8, 2024
Merged
chore: Upgrade controller-runtime version to v0.18.1 #1514
kyma-bot
merged 9 commits into
kyma-project:main
from
Tomasz-Smelcerz-SAP:chore/upgrade-controller-runtime
May 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
Indicates the PR's author has signed the CLA.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
May 2, 2024
Tomasz-Smelcerz-SAP
force-pushed
the
chore/upgrade-controller-runtime
branch
from
May 2, 2024 14:26
4f2fbec
to
3054f6c
Compare
kyma-bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
May 2, 2024
nesmabadr
reviewed
May 2, 2024
kyma-bot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
May 3, 2024
nesmabadr
approved these changes
May 3, 2024
nesmabadr
approved these changes
May 3, 2024
nesmabadr
previously approved these changes
May 3, 2024
It seems that you need to run |
Tomasz-Smelcerz-SAP
added
the
confirm/helm-update
The author explicitly confirms that a Helm update is not needed or is taken care of
label
May 8, 2024
nesmabadr
approved these changes
May 8, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla: yes
Indicates the PR's author has signed the CLA.
confirm/helm-update
The author explicitly confirms that a Helm update is not needed or is taken care of
lgtm
Looks good to me!
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
controller-runtime
in versionv0.18.0
introduced some breaking changes to the event-related APIs.This PR adjusts our code as necessary to work correctly with the upgraded
controller-runtime
.Changes proposed in this pull request:
Related issue(s)