Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make managed-by label value transparent #1894

Merged
merged 18 commits into from
Oct 1, 2024

Conversation

nesmabadr
Copy link
Contributor

@nesmabadr nesmabadr commented Sep 26, 2024

Description

Changes proposed in this pull request:

  • Change managed by label to kyma instead of lifecycle-manager and declarative-v2 for SKR resources

Related issue(s)
Resolves #1821

Verified

This commit was signed with the committer’s verified signature.
…ative-v2
@nesmabadr nesmabadr added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2024
@nesmabadr nesmabadr requested a review from a team as a code owner September 26, 2024 11:02
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 26, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 26, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 26, 2024

Verified

This commit was signed with the committer’s verified signature.
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 26, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 26, 2024
@nesmabadr nesmabadr added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 26, 2024

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 26, 2024
nesmabadr and others added 2 commits September 27, 2024 14:36

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@c-pius c-pius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the following resources that seem to missing the label:

  apiVersion: v1
  kind: Service
  metadata:
    creationTimestamp: "2024-09-30T11:21:49Z"
    name: skr-webhook-metrics
    namespace: kyma-system
    resourceVersion: "594"
    uid: 5d8db776-d102-404b-a46e-6fe17bf22f6f
  spec:
    clusterIP: 10.43.161.169
    clusterIPs:
    - 10.43.161.169
    internalTrafficPolicy: Cluster
    ipFamilies:
    - IPv4
    ipFamilyPolicy: SingleStack
    ports:
    - name: http-metrics
      port: 2112
      protocol: TCP
      targetPort: metrics-port
    selector:
      app: skr-webhook
    sessionAffinity: None
    type: ClusterIP
  status:
    loadBalancer: {}
---
apiVersion: v1
kind: Service
metadata:
  creationTimestamp: "2024-09-30T11:21:49Z"
  name: skr-webhook-metrics
  namespace: kyma-system
  resourceVersion: "594"
  uid: 5d8db776-d102-404b-a46e-6fe17bf22f6f
spec:
  clusterIP: 10.43.161.169
  clusterIPs:
  - 10.43.161.169
  internalTrafficPolicy: Cluster
  ipFamilies:
  - IPv4
  ipFamilyPolicy: SingleStack
  ports:
  - name: http-metrics
    port: 2112
    protocol: TCP
    targetPort: metrics-port
  selector:
    app: skr-webhook
  sessionAffinity: None
  type: ClusterIP
status:
  loadBalancer: {}
---
  apiVersion: v1
  items:
  - apiVersion: operator.kyma-project.io/v1alpha1
    kind: Sample
    metadata:
      creationTimestamp: "2024-09-30T11:26:00Z"
      finalizers:
      - sample.kyma-project.io/finalizer
      generation: 1
      name: sample-yaml
      namespace: kyma-system
      resourceVersion: "783"
      uid: d90013b9-e90c-4205-85dc-23122a1be6c6
    spec:
      resourceFilePath: ./module-data/yaml
    status:
      conditions:
      - lastTransitionTime: "2024-09-30T11:26:01Z"
        message: installation is ready and resources can be used
        observedGeneration: 1
        reason: Ready
        status: "True"
        type: Installation
      state: Ready
  kind: List
  metadata:
    resourceVersion: ""
---
  apiVersion: v1                             
  kind: ServiceAccount                       
    metadata:                                
    creationTimestamp: "2024-09-30T11:25:58Z"
    name: default                            
    namespace: template-operator-system      
    resourceVersion: "735"                   
    uid: 35585fc0-924a-4f37-85d2-ffc5a7cc288f
---

Do we also have documentation on the label that may need to be changed?

api/shared/operator_labels.go Outdated Show resolved Hide resolved
internal/controller/manifest/setup.go Show resolved Hide resolved
internal/remote/crd_upgrade.go Outdated Show resolved Hide resolved
internal/remote/remote_catalog.go Outdated Show resolved Hide resolved
pkg/watcher/skr_webhook_resources.go Outdated Show resolved Hide resolved
c-pius and others added 3 commits September 30, 2024 14:38

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
…cle-manager into managedby_label

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
Copy link
Contributor

@c-pius c-pius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to approve once the linting error is fixed. Really like the change with the MergeMaps util, nice done!

@c-pius
Copy link
Contributor

c-pius commented Oct 1, 2024

I think this one also resolves https://github.com/orgs/kyma-project/projects/30/views/13?pane=issue&itemId=78733805 already?

Verified

This commit was signed with the committer’s verified signature.
@nesmabadr nesmabadr requested a review from c-pius October 1, 2024 07:51
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 1, 2024
@nesmabadr nesmabadr merged commit 7f8e043 into kyma-project:main Oct 1, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make managed-by label more transparent
3 participants