Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Resources as optional to ModuleTemplate #1910

Merged
merged 5 commits into from
Oct 4, 2024
Merged

feat: Add Resources as optional to ModuleTemplate #1910

merged 5 commits into from
Oct 4, 2024

Conversation

c-pius
Copy link
Contributor

@c-pius c-pius commented Oct 1, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • adds new optional Resources field to ModuleTemplate
  • adds documentation for this list
  • does NOT add tests since KLM does not make use of this field itself

Related issue(s)

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 1, 2024
@kyma-bot
Copy link
Contributor

kyma-bot commented Oct 1, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 1, 2024
@c-pius

This comment was marked as resolved.

Sign in to view
@c-pius c-pius marked this pull request as ready for review October 1, 2024 14:51
@c-pius c-pius requested review from a team as code owners October 1, 2024 14:51
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 1, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 4, 2024
@c-pius c-pius merged commit c54809c into kyma-project:main Oct 4, 2024
33 of 34 checks passed
@c-pius c-pius deleted the feat/resources-to-module-template branch October 4, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitoraj mmitoraj mmitoraj approved these changes

@nesmabadr nesmabadr nesmabadr approved these changes

Assignees

@nesmabadr nesmabadr

@mmitoraj mmitoraj

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ModuleCatalog] Add .spec.resources to ModuleTemplate
4 participants
@c-pius @kyma-bot @nesmabadr @mmitoraj