feat: Use ModuleReleaseMeta in Kyma reconciliation loop instead of moduletemplate.channel #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nesmabadr
added
the
do-not-merge/work-in-progress
kyma-bot
added
cla: yes
…r/lifecycle-manager into mrm_kyma_reconciliation
nesmabadr
force-pushed
the
mrm_kyma_reconciliation
branch
2 times, most recently
from
49d1bdb to
f88eeb3
Compare
…r/lifecycle-manager into mrm_kyma_reconciliation
nesmabadr
force-pushed
the
mrm_kyma_reconciliation
branch
from
f88eeb3 to
64ac0f2
Compare
nesmabadr
force-pushed
the
mrm_kyma_reconciliation
branch
from
83771f6 to
8107508
Compare
…r/lifecycle-manager into mrm_kyma_reconciliation
nesmabadr
force-pushed
the
mrm_kyma_reconciliation
branch
from
8107508 to
690cb06
Compare
kyma-bot
added
size/XL
nesmabadr
force-pushed
the
mrm_kyma_reconciliation
branch
from
7ad2bc1 to
90eb7a0
Compare
mmitoraj
reviewed
Oct 15, 2024
There was a problem hiding this comment.
So what are we trying to describe? The mechanism of fetching a correct ModuleTemplate CR for a module? What does Kyma Controller require for that?
- The module name fetched from the corresponding ModuleReleaseMeta CR
- The channel defined in the Kyma CR
- When Kyma Controller knows the module name and its channel it goes back to the ModuleReleaseMeta CR and takes the correct module version for the particular channel
- ...
Here I'm lost because I don't get how the above details help to fetch the correct ModuleTemplate CR...
Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>
nesmabadr
force-pushed
the
mrm_kyma_reconciliation
branch
from
a6c0461 to
6187f69
Compare
mmitoraj
reviewed
Oct 16, 2024
Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>
ruanxin
previously approved these changes
Oct 16, 2024
|
/cla |
|
Successfully reached out to cla-assistant.io to initialize recheck of PR #1947 |
mmitoraj
reviewed
Oct 16, 2024
Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>
mmitoraj
approved these changes
Oct 16, 2024
ruanxin
approved these changes
Oct 16, 2024
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Resolves #1849