feat: Add spec.manager #1958
Merged
feat: Add spec.manager #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
size/L
c-pius
reviewed
Oct 15, 2024
There was a problem hiding this comment.
I was thinking a bit about the name as well. I think staying with manager is okay as we also describe that this is our primary expected case. Also, I still have my doubts if Cloud Manager will even have a use case for manual installation. So I would say it is okay. If we really find that the name is bad, I think we could also rename it in a future API version or even introduce a conversion webhook replacing it with another field name.
Co-authored-by: Christoph Schwägerl <acc.pius@mailbox.org>
Co-authored-by: Christoph Schwägerl <acc.pius@mailbox.org>
Co-authored-by: Christoph Schwägerl <acc.pius@mailbox.org>
Co-authored-by: Christoph Schwägerl <acc.pius@mailbox.org>
kyma-bot
added
size/M
c-pius
previously approved these changes
Oct 15, 2024
mmitoraj
reviewed
Oct 16, 2024
Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>
Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>
Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>
mmitoraj
reviewed
Oct 16, 2024
Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>
c-pius
approved these changes
Oct 16, 2024
mmitoraj
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue(s)
#1840