Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Module release meta watch #1968

Merged
merged 52 commits into from
Oct 30, 2024
Merged

feat: Module release meta watch #1968

merged 52 commits into from
Oct 30, 2024

Conversation

jeremyharisch
Copy link
Contributor

@jeremyharisch jeremyharisch commented Oct 17, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

Related issue(s)

@jeremyharisch jeremyharisch requested review from a team as code owners October 17, 2024 14:11
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 17, 2024
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 24, 2024
@jeremyharisch jeremyharisch changed the title Module release meta watch feat: Module release meta watch Oct 28, 2024
@jeremyharisch jeremyharisch linked an issue Oct 29, 2024 that may be closed by this pull request
[ModuleCatalog] Adapt Watch Mechanism to Monitor ModuleReleaseMeta CR Changes #1850
Closed
6 tasks
nesmabadr
nesmabadr reviewed Oct 30, 2024
View reviewed changes
docs/contributor/04-local-test-setup.md Outdated Show resolved Hide resolved
pkg/watch/module_release_meta_change.go Outdated Show resolved Hide resolved
pkg/watch/module_release_meta_change.go Outdated Show resolved Hide resolved
pkg/watch/module_release_meta_change.go Outdated Show resolved Hide resolved
tests/e2e/modulereleasemeta_watch_trigger_test.go Outdated Show resolved Hide resolved
nesmabadr
nesmabadr previously approved these changes Oct 30, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 30, 2024
mmitoraj
mmitoraj reviewed Oct 30, 2024
View reviewed changes
docs/contributor/02-controllers.md Outdated Show resolved Hide resolved
docs/contributor/02-controllers.md Outdated Show resolved Hide resolved
@jeremyharisch @mmitoraj
Apply suggestions from code review
d8fda47 
Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 30, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 30, 2024
@jeremyharisch jeremyharisch merged commit 2453efe into kyma-project:main Oct 30, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitoraj mmitoraj mmitoraj approved these changes

@nesmabadr nesmabadr nesmabadr approved these changes

Assignees

@nesmabadr nesmabadr

@mmitoraj mmitoraj

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ModuleCatalog] Adapt Watch Mechanism to Monitor ModuleReleaseMeta CR Changes
4 participants
@jeremyharisch @nesmabadr @mmitoraj @kyma-bot