chore: Fix Build Image tags #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
c-pius
force-pushed
the
chore/fix-image-build-tags
branch
from
2d376cb to
1d748c2
Compare
nesmabadr
approved these changes
Oct 18, 2024
This was referenced Oct 21, 2024
c-pius
added a commit
to kyma-project/template-operator
that referenced
this pull request
Oct 21, 2024
<!-- Thank you for your contribution. Before you submit the pull request: 1. Follow contributing guidelines, templates, the recommended Git workflow, and any related documentation. 2. Read and submit the required Contributor Licence Agreements (https://github.com/kyma-project/community/blob/main/CONTRIBUTING.md#agreements-and-licenses). 3. Test your changes and attach their results to the pull request. 4. Update the relevant documentation. --> **Description** Changes proposed in this pull request: - fixes the provided custom tags `pull_request_target` makes this PR use the old image build func here. Didn't test separately again because it has been tested as part of: kyma-project/lifecycle-manager#1970 **Related issue(s)** <!-- If you refer to a particular issue, provide its number. For example, `Resolves #123`, `Fixes #43`, or `See also #33`. --> - partially closes https://github.com/orgs/kyma-project/projects/30/views/13?pane=issue&itemId=83441848
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
pull_request_targetmakes this PR use the old image build func here. Actual test is here: #1971Related issue(s)