Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Provide condition for Manifests stuck in Deleting due to DefaultCR Warning #1988

Merged
merged 39 commits into from
Nov 5, 2024
Merged

feat: Provide condition for Manifests stuck in Deleting due to DefaultCR Warning #1988

merged 39 commits into from
Nov 5, 2024

Conversation

ruanxin
Copy link
Contributor

@ruanxin ruanxin commented Oct 25, 2024 •
edited
Loading

Description
This PR

  • add Module CR is in Warning state condition to Manifest
  • the rest code is basically refactoring to make manifest reconciler more readable

Related issue(s)
#1830

@ruanxin
- remove preDelete and PostRun hook
db84124 
- extract code related to manifest.status to new package
@ruanxin
Merge remote-tracking branch 'upstream/main' into Provide-condition-a…
7d21840 
…nd-metrics-for-Manifests-stuck-in-Deleting-state-due-to-DefaultCR-Warning
@ruanxin
resolve cycle import
d1f8249
@ruanxin
renaming
e8727c4
@ruanxin
relocate finalizer related code
b028f7a 
add RemoveModuleCR test
@ruanxin
gofmt
7c43a85
@ruanxin
remove mis commited file
64000e0
@ruanxin
Merge remote-tracking branch 'upstream/main' into Provide-condition-a…
11086aa 
…nd-metrics-for-Manifests-stuck-in-Deleting-state-due-to-DefaultCR-Warning
@ruanxin
add metrics lifecycle_mgr_module_condition
6f6173a
@ruanxin ruanxin requested a review from a team as a code owner October 25, 2024 10:43
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 25, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 31, 2024
@ruanxin ruanxin changed the title chore: Provide condition and metrics for Manifests stuck in Deleting due to DefaultCR Warning chore: Provide condition for Manifests stuck in Deleting due to DefaultCR Warning Nov 4, 2024
@ruanxin ruanxin changed the title chore: Provide condition for Manifests stuck in Deleting due to DefaultCR Warning feat: Provide condition for Manifests stuck in Deleting due to DefaultCR Warning Nov 4, 2024
@lindnerby lindnerby self-assigned this Nov 4, 2024
@lindnerby
Merge branch 'main' into Provide-condition-and-metrics-for-Manifests-…
ff900ba 
…stuck-in-Deleting-state-due-to-DefaultCR-Warning
@lindnerby lindnerby enabled auto-merge (squash) November 4, 2024 13:35
lindnerby
lindnerby requested changes Nov 4, 2024
View reviewed changes
api/v1beta2/manifest_types.go Outdated Show resolved Hide resolved
internal/manifest/finalizer/handler.go Show resolved Hide resolved
internal/manifest/skrresources/sync.go Show resolved Hide resolved
ruanxin and others added 7 commits November 4, 2024 16:24
@ruanxin
add unit test for RemoveCRFinalizer
57725ae
@ruanxin
Merge remote-tracking branch 'origin/Provide-condition-and-metrics-fo…
ba6a002 
…r-Manifests-stuck-in-Deleting-state-due-to-DefaultCR-Warning' into fork/ruanxin/Provide-condition-and-metrics-for-Manifests-stuck-in-Deleting-state-due-to-DefaultCR-Warning
@ruanxin
adjust coverage
54bf047
@ruanxin
Merge remote-tracking branch 'upstream/main' into fork/ruanxin/Provid…
3d6437e 
…e-condition-and-metrics-for-Manifests-stuck-in-Deleting-state-due-to-DefaultCR-Warning
@ruanxin
update coverage report
3312f49
@ruanxin
update coverage
1e6be6d
@lindnerby
Merge branch 'main' into Provide-condition-and-metrics-for-Manifests-…
6f70ad5 
…stuck-in-Deleting-state-due-to-DefaultCR-Warning
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 5, 2024
@ruanxin
Merge branch 'main' into Provide-condition-and-metrics-for-Manifests-…
4732c5c 
…stuck-in-Deleting-state-due-to-DefaultCR-Warning
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Nov 5, 2024
@kyma-bot
Copy link
Contributor

kyma-bot commented Nov 5, 2024

New changes are detected. LGTM label has been removed.

@lindnerby lindnerby merged commit aaf6b0b into kyma-project:main Nov 5, 2024
62 of 63 checks passed
@lindnerby lindnerby assigned ruanxin and unassigned lindnerby Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindnerby lindnerby lindnerby approved these changes

Assignees

@ruanxin ruanxin

Labels
cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruanxin @kyma-bot @lindnerby