Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use separate ModuleConfig files for the E2E tests #2013

Merged
merged 2 commits into from
Nov 6, 2024
Merged

chore: Use separate ModuleConfig files for the E2E tests #2013

merged 2 commits into from
Nov 6, 2024

Conversation

nesmabadr
Copy link
Contributor

@nesmabadr nesmabadr commented Nov 5, 2024 •
edited
Loading

Description
In order to support URLs for the manifest in the template operator module config file, we need to have separate module config files for different deployment/ statefulset arguments

Changes proposed in this pull request:

  • Use separate ModuleConfig files for the E2E

Related issue(s)

@nesmabadr nesmabadr added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2024
@nesmabadr nesmabadr requested a review from a team as a code owner November 5, 2024 10:12
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2024
@nesmabadr nesmabadr mentioned this pull request Nov 5, 2024
Merged
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2024
@nesmabadr nesmabadr changed the title [DONOT MERGE] Test the e2e tests with the new template-operator moduleconfig chore: Use separate ModuleConfig files for the E2E tests Nov 5, 2024
@nesmabadr nesmabadr force-pushed the test_new_moduleconfig branch 3 times, most recently from 6767bb6 to 4a282da Compare November 5, 2024 11:06
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 5, 2024
@nesmabadr nesmabadr force-pushed the test_new_moduleconfig branch from 4a282da to ce0cd72 Compare November 5, 2024 12:00
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 5, 2024
@nesmabadr nesmabadr removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2024
@nesmabadr nesmabadr force-pushed the test_new_moduleconfig branch from ce0cd72 to 57982d2 Compare November 5, 2024 12:46
@lindnerby lindnerby self-assigned this Nov 6, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 6, 2024
@lindnerby lindnerby merged commit b1541f7 into kyma-project:main Nov 6, 2024
63 checks passed
@lindnerby lindnerby assigned nesmabadr and unassigned lindnerby Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindnerby lindnerby lindnerby approved these changes

Assignees

@nesmabadr nesmabadr

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nesmabadr @lindnerby @kyma-bot