Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix module version downgrade bug with the new ModuleTemplate #2043

Merged
merged 19 commits into from
Nov 22, 2024

Conversation

nesmabadr
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Fix the module version downgrade bug with the new ModuleTemplate
  • Adapt tests
  • Adjust E2E test to assert on the module message in kyma.status

Related issue(s)
Resolves #2036

@nesmabadr nesmabadr added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2024
@nesmabadr nesmabadr requested a review from a team as a code owner November 21, 2024 11:38
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 21, 2024
@nesmabadr nesmabadr added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2024
@nesmabadr nesmabadr removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 22, 2024
@nesmabadr nesmabadr merged commit dd8ba97 into kyma-project:main Nov 22, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Module Catalog] New ModuleTemplate with ModuleReleaseMeta can't prevent version downgrade
3 participants