Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle Race Condition for Istio Gateway Secret #2078

Merged
merged 13 commits into from
Dec 2, 2024
Merged

fix: Handle Race Condition for Istio Gateway Secret #2078

merged 13 commits into from
Dec 2, 2024

Conversation

LeelaChacha
Copy link
Contributor

Fix for #2004

@LeelaChacha LeelaChacha requested a review from a team as a code owner November 29, 2024 11:15
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 29, 2024
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 29, 2024
@c-pius
Copy link
Contributor

c-pius commented Nov 29, 2024

FYI: we also had some checkmarx related issues: #2075
I think we can close my PR in favor of yours, would you mind double checking the fixes though? Maybe you will need to change the passing of the configs and the panics in the same way.

@LeelaChacha
Copy link
Contributor Author

LeelaChacha commented Nov 29, 2024 •
edited
Loading

the panics

WDYT about my comment on the panic? Should the goroutine exit with a bootstrap error? @c-pius

ruanxin
ruanxin requested changes Dec 1, 2024
View reviewed changes
Copy link
Contributor

@ruanxin ruanxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check my comments

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 2, 2024
@nesmabadr nesmabadr enabled auto-merge (squash) December 2, 2024 15:44
@nesmabadr nesmabadr merged commit 9974549 into kyma-project:main Dec 2, 2024
63 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanxin ruanxin ruanxin approved these changes

Assignees

@ruanxin ruanxin

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LeelaChacha @c-pius @ruanxin @nesmabadr @kyma-bot