Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Refactor available module #2120

Merged
merged 44 commits into from
Dec 19, 2024
Merged

chore: Refactor available module #2120

merged 44 commits into from
Dec 19, 2024

Conversation

medmes
Copy link
Member

@medmes medmes commented Dec 13, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Rename availableModule
  • refactor accordingly
  • added unit tests

Related issue(s)

#1638

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 13, 2024
@medmes medmes linked an issue Dec 13, 2024 that may be closed by this pull request
Rename AvailableModule #1638
Closed
3 tasks
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 13, 2024
@medmes medmes closed this Dec 13, 2024
@medmes medmes reopened this Dec 13, 2024
@medmes medmes closed this Dec 13, 2024
@medmes medmes reopened this Dec 13, 2024
@medmes medmes changed the title refactor available module chore: Refactor available module Dec 13, 2024
@medmes
refactor available module
13190c4 
# Conflicts:
#	pkg/templatelookup/regular.go
@medmes
feat: Prevent unallowed internal/beta module installation (kyma-proje…
42fbe5d 
…ct#2111)

* feat: Prevent unallowed internal/beta module installation

* fix linting

* tests to allow ireturn

* refactor mrm fetching

* fix tests

* revert receiver to normal func

* remove unnecessary context

* add missing testcases
# Conflicts:
#	pkg/templatelookup/regular.go
@medmes
feat: Prevent unallowed internal/beta module installation (kyma-proje…
f2ef866 
…ct#2111)

* feat: Prevent unallowed internal/beta module installation

* fix linting

* tests to allow ireturn

* refactor mrm fetching

* fix tests

* revert receiver to normal func

* remove unnecessary context

* add missing testcases
# Conflicts:
#	pkg/templatelookup/regular.go
@medmes
add empty spec and status unit test
701bdc3
@medmes
rename old function into FetchModuleStatusInfo
dd5893d
@medmes medmes force-pushed the refactor_available_module branch from 6d69b27 to dd5893d Compare December 13, 2024 11:06
@medmes
Copy link
Member Author

medmes commented Dec 13, 2024

/retest

@medmes medmes marked this pull request as ready for review December 16, 2024 08:04
@medmes medmes requested a review from a team as a code owner December 16, 2024 08:04
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2024
@medmes
Copy link
Member Author

medmes commented Dec 16, 2024

/retest

ruanxin
ruanxin reviewed Dec 16, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@c-pius c-pius force-pushed the refactor_available_module branch from 4da9ed7 to 868a81b Compare December 17, 2024 07:57
medmes added 16 commits December 17, 2024 09:42
@medmes
Merge branch 'refactor_available_module' of github.com:medmes/lifecyc…
4adb34f 
…le-manager into refactor_available_module
@medmes
Merge branch 'main' of github.com:kyma-project/lifecycle-manager into…
85e41a7 
… refactor_available_module
@medmes
Merge branch 'main' into refactor_available_module
cf12cb6
@medmes
Refactor code and algorithm optimization to O(n+m)
70c1d6b
@medmes
Merge branch 'main' into refactor_available_module
8340c19
@medmes
revert back to Enabled and Managed
7042d7f
@medmes
Revert "Refactor code and algorithm optimization to O(n+m)"
092ff82 
This reverts commit 70c1d6b
@medmes
Merge branch 'main' into refactor_available_module
ec45b25
@medmes
delete unused code
0c00db5
@medmes
revert to old state
13f68de
@medmes
revert ide new line added
30507dd
@medmes
revert ide new line added
812c99e
@medmes
delete unused code
fc483f6
@medmes
Update moduleinfo_test.go
621e59b
@medmes
Revert "Update moduleinfo_test.go"
31dbec5 
This reverts commit 621e59b.
@medmes
revert ide new line added
1510aab
@medmes
Copy link
Member Author

medmes commented Dec 18, 2024

/cla

@kyma-bot
Copy link
Contributor

Successfully reached out to cla-assistant.io to initialize recheck of PR #2120

c-pius
c-pius reviewed Dec 19, 2024
View reviewed changes
Copy link
Contributor

@c-pius c-pius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it would be fine now. Just one minor fix in a comment, and I would propose to create a follow-up to extend the test cases.

pkg/templatelookup/moduleinfo.go Outdated Show resolved Hide resolved
pkg/templatelookup/moduleinfo_test.go Show resolved Hide resolved
medmes and others added 2 commits December 19, 2024 09:03
@medmes @c-pius
Apply suggestions from code review
46faf45 
Co-authored-by: Christoph Schwägerl <acc.pius@mailbox.org>
@medmes
add comment to fetchModuleInfo function
f05472e
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 19, 2024
@ruanxin ruanxin merged commit a0921e6 into kyma-project:main Dec 19, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-pius c-pius c-pius left review comments

@ruanxin ruanxin ruanxin approved these changes

Assignees

@ruanxin ruanxin

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename AvailableModule
4 participants
@medmes @kyma-bot @ruanxin @c-pius