Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Flaky remote_sync_test #2129

Merged
merged 3 commits into from
Dec 17, 2024
Merged

fix: Flaky remote_sync_test #2129

merged 3 commits into from
Dec 17, 2024

Conversation

c-pius
Copy link
Contributor

@c-pius c-pius commented Dec 16, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • fixes the Flaky remote_sync_test integration test
  • makes the re-try on create module templates more robust
  • in total, 5 consecutive executions succeeded now (previously we had roughly a 50/50 chance)

Related issue(s)

@c-pius c-pius requested a review from a team as a code owner December 16, 2024 13:43
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 16, 2024
@c-pius c-pius force-pushed the fix/flaky-remote-sync-tests branch from fa71fac to f41cb2d Compare December 16, 2024 13:43
@c-pius c-pius force-pushed the fix/flaky-remote-sync-tests branch from f41cb2d to 8566345 Compare December 16, 2024 14:03
@c-pius
Copy link
Contributor Author

c-pius commented Dec 16, 2024

/cla

@kyma-bot
Copy link
Contributor

Successfully reached out to cla-assistant.io to initialize recheck of PR #2129

@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 16, 2024
@c-pius c-pius enabled auto-merge (squash) December 16, 2024 16:24
@c-pius c-pius force-pushed the fix/flaky-remote-sync-tests branch from 0dd60cf to 352923c Compare December 17, 2024 08:04
@c-pius c-pius merged commit dc24a99 into kyma-project:main Dec 17, 2024
65 of 66 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 17, 2024
@c-pius c-pius deleted the fix/flaky-remote-sync-tests branch December 17, 2024 09:52
@c-pius c-pius assigned c-pius and unassigned medmes Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medmes medmes medmes approved these changes

Assignees

@c-pius c-pius

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c-pius @kyma-bot @medmes