Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Maintenance Windows resolver module #2155

Merged
merged 12 commits into from
Jan 3, 2025
Merged

feat: Maintenance Windows resolver module #2155

merged 12 commits into from
Jan 3, 2025

Conversation

Tomasz-Smelcerz-SAP
Copy link
Member

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP commented Dec 30, 2024 •
edited
Loading

Description

Adding a small sub-module for sharing maintenance windows related code between projects
The following was added to the original code:

  • Used the same linting configuration that is used in the Lifecycle-Manager, adjusted the code as necessary
  • Add a small initial README.md

Fixes: #2114

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP requested a review from a team as a code owner December 30, 2024 08:07
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 30, 2024
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed cla: yes Indicates the PR's author has signed the CLA. labels Dec 30, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 30, 2024
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP force-pushed the feat/maintenance-window-shared-code branch from 6aaaec5 to 326eb78 Compare January 2, 2025 06:58
c-pius
c-pius reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@c-pius c-pius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this can be imported as a standalone module, I would suggest that we also add a maintenancewindows/README.md explaining the background of this. WDYT?

maintenancewindows/resolver/resolver.go Outdated Show resolved Hide resolved
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP force-pushed the feat/maintenance-window-shared-code branch from af91ca6 to be2d412 Compare January 2, 2025 13:11
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP requested a review from a team as a code owner January 3, 2025 08:02
c-pius
c-pius previously approved these changes Jan 3, 2025
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 3, 2025
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP enabled auto-merge (squash) January 3, 2025 10:56
nataliasitko
nataliasitko reviewed Jan 3, 2025
View reviewed changes
maintenancewindows/README.md Outdated Show resolved Hide resolved
maintenancewindows/README.md Outdated Show resolved Hide resolved
@Tomasz-Smelcerz-SAP @nataliasitko
Update maintenancewindows/README.md
4a2da2f 
Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 3, 2025
@Tomasz-Smelcerz-SAP @nataliasitko
Update maintenancewindows/README.md
1c1f485 
Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 3, 2025
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP merged commit 7ed9a31 into kyma-project:main Jan 3, 2025
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliasitko nataliasitko nataliasitko approved these changes

@c-pius c-pius c-pius approved these changes

Assignees

@c-pius c-pius

@nataliasitko nataliasitko

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maintenance Windows] Create go module for MaintenanceWindowPolicy resolver
4 participants
@Tomasz-Smelcerz-SAP @c-pius @nataliasitko @kyma-bot