Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme to include steps to install latest NATS manager and CR #206

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

marcobebway
Copy link
Contributor

Description

Update readme to include steps to install latest NATS manager and CR.

@marcobebway marcobebway requested a review from a team as a code owner October 27, 2023 13:43
@marcobebway marcobebway self-assigned this Oct 27, 2023
@marcobebway marcobebway added the area/eventing Issues or PRs related to eventing label Oct 27, 2023
@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 27, 2023
@marcobebway marcobebway added documentation Improvements or additions to documentation and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 27, 2023
@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 27, 2023
mfaizanse
mfaizanse previously approved these changes Oct 27, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 27, 2023
Copy link
Contributor

@NHingerl NHingerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember that on the OS website, doc Install Kyma with a Module, will also need these commands when we're GA.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated

Run the following command to install the latest version of the NATS manager on your cluster:

```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add 3 blank spaces to each line of the code block

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

README.md Outdated

Run the following command to install the latest version of the default NATS CR on your cluster:

```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add 3 blank spaces to each line of the code block

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Co-authored-by: Nina Hingerl <76950046+NHingerl@users.noreply.github.com>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 31, 2023
marcobebway and others added 2 commits October 31, 2023 13:16
Co-authored-by: Nina Hingerl <76950046+NHingerl@users.noreply.github.com>
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 31, 2023
@kyma-bot kyma-bot merged commit 66f0d5e into kyma-project:main Oct 31, 2023
3 checks passed
@marcobebway marcobebway deleted the update-readme branch October 31, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing documentation Improvements or additions to documentation lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants