Install NATS Manager w/o LM #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
Don't use lifecycle manager to install nats-manager
kyma-bot
added
size/M
* Execute e2e and upgrade tests without KLM * Rename GH action workflows accordingl
kyma-bot
added
size/XL
marcobebway
reviewed
Jan 15, 2024
| - name: Install latest NATS manager from main branch | ||
| run: | | ||
| make -C hack/ci/ create-kyma-system-ns | ||
| make deploy IMG=europe-docker.pkg.dev/kyma-project/prod/nats-manager:latest |
There was a problem hiding this comment.
Are we sure that the latest tag always refers to the main head?
Otherwise we can use git CLI to get the latest commit SHA from the main branch.
There was a problem hiding this comment.
yes, I am sure. I've checked it and it is also set here
marcobebway
reviewed
Jan 15, 2024
hack/ci/Makefile
Outdated
Comment on lines
30
to
31
| .PHONY: install-nats-manager | ||
| install-nats-manager: ## Install nats-manager only. |
There was a problem hiding this comment.
Suggested change
| .PHONY: install-nats-manager | |
| install-nats-manager: ## Install nats-manager only. | |
| .PHONY: install-latest-nats-manager-release | |
| install-latest-nats-manager-release: ## Install nats-manager only. |
marcobebway
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use lifecycle manager to install nats-manager. Remove lifecycle-manager names from the jobs.
Moreover, make upgrade tests run for PRs and main branch.
Related issue:
#228