Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add metrics service #376

Closed
wants to merge 3 commits into from
Closed

feat: add metrics service #376

wants to merge 3 commits into from

Conversation

k15r
Copy link
Contributor

@k15r k15r commented May 10, 2024

Description

Changes proposed in this pull request:

  • add a metrics service to enable scraping nats-manager

Related issue(s)

@k15r k15r requested review from a team as code owners May 10, 2024 13:32
@k15r k15r requested a review from marcobebway May 10, 2024 13:32
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 10, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 10, 2024
NHingerl
NHingerl approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@NHingerl NHingerl left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need TW approval for three yaml files?

Aaaah no you don't; I just went wild and reviewed + approved anyway. Monday morning frenzy.

@kyma-bot kyma-bot added the lgtm Looks good to me! label May 13, 2024
@NHingerl NHingerl removed their assignment May 14, 2024
@k15r k15r linked an issue May 22, 2024 that may be closed by this pull request
Create metrics service for NATS-manager #383
Closed
@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 14, 2024
@github-actions GitHub Actions
Copy link

This pull request has been automatically closed due to the lack of recent activity.
/lifecycle rotten

@github-actions github-actions bot closed this Jul 22, 2024
@kyma-bot kyma-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NHingerl NHingerl NHingerl approved these changes

@marcobebway marcobebway Awaiting requested review from marcobebway marcobebway is a code owner automatically assigned from kyma-project/eventing

Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create metrics service for NATS-manager
3 participants
@k15r @NHingerl @kyma-bot