-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support native dockerconfigjson secrets when configuring docker registry for serverless #121
Comments
This issue or PR has been automatically marked as stale due to the lack of recent activity. This bot triages issues and PRs according to the following rules:
You can:
If you think that I work incorrectly, kindly raise an issue with the problem. /lifecycle stale |
According to POC we expect changes in Stages: ( single release )
|
We figured out that the secret with type |
Description
As a user I would like to configure secret of type
kubernetes.io/dockerconfigjson
(i.e using this tutorial) and reference it in my serverless CR to be used as external docker registry.With Serverelss CR we allow user to declare which secret should be used.
Serverless manager should take the
dockerconfigjson
data and apply in the owned copy (serverless-registry-config-default
) that is then being replicated accross namespaces.For the sake of simplicity we should not force the user to fill in the extra labels or anything else than k8s standard.
Reason
Conforming with kubernetes known types of secrets simplifies the adoption of kyma serverless.
Additionally, we can reduce maintanance costs as this would allow us to rely on kubernetes CLI and deprecate the defaulting logic in our webhook that currently generates the
data.dockerconfigjson
contentThe text was updated successfully, but these errors were encountered: