Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decompose Serverless webhook #247

Closed
7 tasks done
kwiatekus opened this issue Aug 31, 2023 · 0 comments
Closed
7 tasks done

Decompose Serverless webhook #247

kwiatekus opened this issue Aug 31, 2023 · 0 comments
Labels
2024-Q1 area/serverless Issues or PRs related to serverless kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@kwiatekus
Copy link
Contributor

kwiatekus commented Aug 31, 2023

Description

Get rid of serverless webhook:

Replace validation logic with kubernetes validation rules in CRDs

Move necessary defaulting to controller

Drop excesive unnecessary validation

Eliminate mutation of docker registry secret

Reasons

By getting rid of our webhook we can improve resiliency of serverless module and remove the problem of CA generation.
Webhooks are intercepting calls to apiserver and introduce another point of failure.
User can apply functions CR only after webhook is up, and it takes it a while until its up.
If we get rid of webhooks we will enable true declarative way of defining function - this improves development experience for function developers.

Attachments

Succesful POC
https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#validation

@kwiatekus kwiatekus added kind/feature Categorizes issue or PR as related to a new feature. area/serverless Issues or PRs related to serverless labels Aug 31, 2023
@kwiatekus kwiatekus changed the title Eliminate Serverless webhook Decompose Serverless webhook Sep 6, 2023
@kwiatekus kwiatekus added 2024-Q1 and removed 2023-Q3 labels Nov 2, 2023
@kwiatekus kwiatekus added this to the 1.3.0 milestone Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024-Q1 area/serverless Issues or PRs related to serverless kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant