Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop validation logic for Function's spec.replicas #251

Closed
Tracked by #247
kwiatekus opened this issue Aug 31, 2023 · 0 comments
Closed
Tracked by #247

Drop validation logic for Function's spec.replicas #251

kwiatekus opened this issue Aug 31, 2023 · 0 comments
Assignees
@pPrecel
Labels
area/serverless Issues or PRs related to serverless kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@kwiatekus
Copy link
Contributor

Description

Get rid of validation for spec.replicas (between ScaleConfig.min/max values)

Reasons

A spec.scaleConfig indicates that function scaling is delegated to HPA - and it is HPA that should controll spec.replicas field and it will never go beyond the min.max values. In case spec.scaleConfig is missing, user (manually) or external scaler drives scaling and there should be no internal constraints for the amount of replicas.

Also - our goal is to remove serverless webhook ( see the linked epic )

Attachments
@kwiatekus kwiatekus added area/serverless Issues or PRs related to serverless kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Aug 31, 2023
@kwiatekus kwiatekus mentioned this issue Aug 31, 2023
Closed
7 tasks
@pPrecel pPrecel self-assigned this Sep 13, 2023
@pPrecel pPrecel mentioned this issue Sep 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pPrecel pPrecel

Labels
area/serverless Issues or PRs related to serverless kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kwiatekus @pPrecel