Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop function requested resources vs limit validation from the serverless webhook #249

Closed
Tracked by #247
kwiatekus opened this issue Aug 31, 2023 · 2 comments
Closed
Tracked by #247
Assignees
Labels
area/serverless Issues or PRs related to serverless kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@kwiatekus
Copy link
Contributor

kwiatekus commented Aug 31, 2023

Description
Comparing if requested cpu and memory resources do not exceed (cpu and memory) limits should be dropped from validation webhook.

Misconfigured function specs should show an error message in status.conditions

Reasons
Our goal is to remove serverless webhook ( see the linked epic )

Attachments
kubernetes-sigs/controller-tools#827

@kwiatekus kwiatekus added area/serverless Issues or PRs related to serverless kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Aug 31, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Nov 6, 2023

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

@kyma-bot kyma-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 6, 2023
@kwiatekus kwiatekus removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 13, 2023
@dbadura dbadura self-assigned this Nov 20, 2023
@dbadura
Copy link
Contributor

dbadura commented Nov 23, 2023

Example error of wrongly confifured resources for function:

    {
      "lastTransitionTime": "2023-11-23T10:31:30Z",
      "message": "Function limits cpu(100m) should be higher than requests cpu(250m). Function limits memory(100Mi) should be higher than requests memory(150Mi)",
      "reason": "InvalidFunctionSpec",
      "status": "False",
      "type": "ConfigurationReady"
    },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/serverless Issues or PRs related to serverless kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

3 participants