Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controller validation #433

Merged
merged 6 commits into from
Nov 23, 2023
Merged

Controller validation #433

merged 6 commits into from
Nov 23, 2023

Conversation

dbadura
Copy link
Contributor

@dbadura dbadura commented Nov 21, 2023

Description

Changes proposed in this pull request:

  • add validation with minimum resources
  • add ability to create function with limits only
  • add more precise tests

Related issue(s)
#249

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2023
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 21, 2023
@dbadura
Copy link
Contributor Author

dbadura commented Nov 21, 2023

/test all

@dbadura dbadura marked this pull request as ready for review November 22, 2023 13:39
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 22, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Nov 22, 2023 •
edited
Loading

@dbadura: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-serverless-controller-lint 0ae5912 link false /test pre-serverless-controller-lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kwiatekus
kwiatekus reviewed Nov 23, 2023
View reviewed changes
components/serverless/Makefile
@@ -109,7 +109,7 @@ else
@echo "Image signing skipped"
endif

install-manager-k3d: build-image-function-controller
install-manager-k3d: build-image-function-controller disable-operator
Copy link
Contributor

@kwiatekus kwiatekus Nov 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general purpose is clear, but it feels like abusing the make targets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current installation process broke this target. This target is intended to use for local development. The fix is simple and I would keep it.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 23, 2023
@kyma-bot kyma-bot merged commit a7c6627 into kyma-project:main Nov 23, 2023
13 of 14 checks passed
@dbadura dbadura deleted the controller-validation-2 branch November 23, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwiatekus kwiatekus kwiatekus left review comments

@Cortey Cortey Cortey approved these changes

@m00g3n m00g3n Awaiting requested review from m00g3n

@pPrecel pPrecel Awaiting requested review from pPrecel pPrecel is a code owner

@anoipm anoipm Awaiting requested review from anoipm anoipm is a code owner

@MichalKalke MichalKalke Awaiting requested review from MichalKalke MichalKalke is a code owner

Assignees

@Cortey Cortey

Labels
lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dbadura @kyma-bot @kwiatekus @Cortey