Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook resource validation removal #438

Merged

Conversation

dbadura
Copy link
Contributor

@dbadura dbadura commented Nov 23, 2023

Description

Changes proposed in this pull request:

  • Remove validation from webhook
  • Fix situation when function is fixed after getting an error
  • Fix makefile to work without root priviledges

Related issue(s)
#249

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2023
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 23, 2023
@dbadura dbadura changed the title Webhook resourve validation removal Webhook resource validation removal Nov 23, 2023
@dbadura
Copy link
Contributor Author

dbadura commented Nov 23, 2023

/test all

@dbadura dbadura marked this pull request as ready for review November 24, 2023 14:38
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2023
@kyma-bot
Copy link
Contributor

@dbadura: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-serverless-controller-lint c35226e link false /test pre-serverless-controller-lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Cortey Cortey self-assigned this Nov 27, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 27, 2023
@kyma-bot kyma-bot merged commit 029f994 into kyma-project:main Nov 27, 2023
15 of 16 checks passed
@dbadura dbadura deleted the webhook-resourve-validation-removal branch November 27, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants