Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add first version of x-kuberneets impl with unit tests #338

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Add first version of x-kuberneets impl with unit tests #338

merged 5 commits into from
Oct 16, 2023

Conversation

dbadura
Copy link
Contributor

@dbadura dbadura commented Oct 5, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • add unit test to validate correctness of x-kubernetes-validations
  • add validation for labels

Related issue(s)
#250

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 5, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Oct 5, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 5, 2023
@dbadura
Copy link
Contributor Author

dbadura commented Oct 5, 2023

/test all

@dbadura
Copy link
Contributor Author

dbadura commented Oct 5, 2023

/test all

@dbadura dbadura force-pushed the x-kubernetes-validations branch 6 times, most recently from e131a14 to d835006 Compare October 13, 2023 12:15
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 13, 2023
@dbadura dbadura marked this pull request as ready for review October 13, 2023 12:41
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2023
@dbadura
Copy link
Contributor Author

dbadura commented Oct 13, 2023

/retest

@dbadura
Copy link
Contributor Author

dbadura commented Oct 13, 2023

/retest

anoipm
anoipm reviewed Oct 13, 2023
View reviewed changes
components/serverless/.gitignore
@@ -28,3 +28,6 @@ vendor/
cover.out
filered.cov
log_config.yaml

# Directory with temporary files used to do development
hack/test_files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where and why we use this directory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was using it to keep local test files.

components/serverless/Makefile Outdated Show resolved Hide resolved
@anoipm anoipm self-assigned this Oct 13, 2023
@dbadura
Copy link
Contributor Author

dbadura commented Oct 13, 2023

/retest

@kyma-bot
Copy link
Contributor

kyma-bot commented Oct 13, 2023 •
edited
Loading

@dbadura: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-function-controller-lint bd30f29 link false /test pull-function-controller-lint
pre-serverless-runtimes-java17-jvm-alpha-build bd30f29 link true /test pre-serverless-runtimes-java17-jvm-alpha-build
pre-serverless-runtimes-nodejs-v16-build bd30f29 link true /test pre-serverless-runtimes-nodejs-v16-build
pre-serverless-runtimes-nodejs-v18-build bd30f29 link true /test pre-serverless-runtimes-nodejs-v18-build
pre-serverless-runtimes-python39-build bd30f29 link true /test pre-serverless-runtimes-python39-build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dbadura
Copy link
Contributor Author

dbadura commented Oct 16, 2023

/retest

@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 16, 2023
@kyma-bot kyma-bot merged commit 1c1b51c into kyma-project:main Oct 16, 2023
14 checks passed
@dbadura dbadura deleted the x-kubernetes-validations branch October 17, 2023 07:14
@Cortey Cortey mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoipm anoipm anoipm approved these changes

@m00g3n m00g3n Awaiting requested review from m00g3n

@pPrecel pPrecel Awaiting requested review from pPrecel pPrecel is a code owner

@kwiatekus kwiatekus Awaiting requested review from kwiatekus kwiatekus is a code owner

@Cortey Cortey Awaiting requested review from Cortey Cortey is a code owner

@MichalKalke MichalKalke Awaiting requested review from MichalKalke MichalKalke is a code owner

Assignees

@anoipm anoipm

Labels
lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dbadura @kyma-bot @anoipm