Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github actions node version upgrade #577

Closed
Nathanwoodburn opened this issue Nov 8, 2022 · 1 comment · Fixed by #597
Closed

Github actions node version upgrade #577

Nathanwoodburn opened this issue Nov 8, 2022 · 1 comment · Fixed by #597

Comments

@Nathanwoodburn
Copy link

Nathanwoodburn commented Nov 8, 2022

This isn't a bug (but I can't seem to create other issues types)

Github has depreciated node.js 12. So we should update Bob to node.js 16
I'm not sure if this will change anything or is just quick fix.
See https://github.com/kyokan/bob-wallet/actions/runs/3326674191 and https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Screencap

image

@rithvikvibhu
Copy link
Collaborator

That's weird, we already use only node 16 in both workflow files. Not sure where that's coming from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants