Bulk fixes 2 #597
Merged
Bulk fixes 2 #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, be aware of custom hsd location
rithvikvibhu
added
the
needs translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
settings: save log file by file copy
(closes #556)
"Download Log" in settings used to read from file, send over IPC to renderer and then downloading as blob. This has a size limit and often didn't save the complete log file (which can be as big as 20 MB).
Also, log file was only saved if hsd path hadn't been changed from the default path.
This commit replaces the read+save with an fs copyFile and also takes care of custom hsd dir path.
watchlist: refresh name state on new blocks
(resolves part of #570)
BlockStatusnow refreshes a name on height change (and throttled as usual to 10 secs). Watching (and other pages where BlockStatus is used) will update dates as and when states change.sign-msg: sort names dropdown properly
In some cases, the correct name was not used to sign messages. This has been fixed by sorting the names earlier.
pkg: fix CSP with correct values
On every start, the console had a CSP error that users mistook for a real error. This commit moves the CSP into app.html, removes the replacer in package scripts, and cleans up the values.
ui: pass strings instead of bool to autoComplete
Javascript
falsewas passed to a textarea's autoComplete and autoCorrect and this threw errors. They are now strings"false"as required.ci: add macos builds
Adds macos to the package workflow (that's triggered manually, not related to build-and-test that runs on PRs). These DMGs aren't signed and won't run, but with https://github.com/indygreg/apple-platform-rs/tree/main/apple-codesign it should be possible to download this and sign it on non-macos devices!
ci: update actions
(closes #577)
Old nodejs and upload artifacts were showing warnings in GH action runs, updated them. And we have npm caching now that should slightly speed up repeated builds.
ci: add retry for flaky npm install on windows
(closes (maybe) #595)
See issue why windows builds randomly fails. This adds a retry action which retries failed npm install up to 3 times.
send: extract HIP-2 address field as component
The HIP-2 address field was tightly part of the Send page. This commit extracts all that logic to a new
AddressInputcomponent. This was done because...my-domain: use HIP-2 address for transfer
(closes #572)
...the transfer section can use the same
AddressInput. Now names can be transferred to HIP-2 aliases.