Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

my-domain: only show possible actions #288

Merged
merged 5 commits into from
Jan 24, 2021

Conversation

rithvikvibhu
Copy link
Collaborator

@rithvikvibhu rithvikvibhu commented Jan 15, 2021

Closes #185, Closes #147.

This PR:

  • Shows Send Register instead of Send Renewal in My Domain when the name is not registered
  • Does not allow transfer when the name is not registered
  • Change label Your Bids to Bids in My Domain as all bids are shown
  • Show Register my domain instead of Renew my domain on Auctions page when the name is not registered

image
image

@rithvikvibhu
Copy link
Collaborator Author

Also including #147 because it's similar.

When a name is won (and the name isn't registered), the Auction page now shows a Register button instead of Renew.
After registering, it switches to Renew.

Kept the manage button in place because it lets you go the Domain Manager page to update records (alternative to Register button).

image
image

@chikeichan chikeichan merged commit a613ddf into kyokan:master Jan 24, 2021
@rithvikvibhu rithvikvibhu deleted the register-on-my-domain-page branch January 24, 2021 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renewal button/link is active when it's not permitted Confusion around "register"
2 participants