Sidebar and friends #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rithvikvibhu
added a commit
that referenced
this pull request
Jan 30, 2023
* temp * use api key * wallet: set display name based on wallet type * ui: change copy button text on copy * ducks: add more wallet properties * onboarding: create multisig wallet * onboarding: import multisig wallet * wallet: refactor to use walletProxy * wallet: parse tx and multisigProxy * multisig: setup and keys table * multisig: tx viewer modal * multisig: add modal to inspect tx * ui: do not show success notifs if partial signed tx * ui: hide elements in uninitialised wallets * atomic-swap: add transaction file select * ui: disable features not supported with multisig * multisig: add i18n context * wallet: remove unused tx create code * i18n: extract strings * onboarding: refactor CreateNewAccount * wallet: only add redeem script to LedgerInput if p2sh * multisig: only show export in modal after signing * multisig: check tx before broadcast from modal * multisig: success notification after broadcast * onboarding: limit multisig N to max 15 * multisig: error when adding existing key * Fixed line 107 of package.js (#3) * Fixed line 107 of package.js Changed claims.js to notifications.js in scripts/package.js * Added both claims and notifications to package.js and .sh Co-authored-by: Nathan Woodburn <contact@nathan.woodburn.id.au> * ui: do not show success notification if not broadcasting * multisig: handle incomplete txs with negative fee * multisig: new multisig section in tx viewer * multisig: copy tx hex in modal For debugging and palmreader users * ui: do not show error if user cancelled modal * multisig: consider 0 bid as valid * i18n: extract strings from multisig components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After building the sidebar, I've walked through the codebase and started implementing + redesigning existing pages / components. This is obviously WIP - we need to improve design for consistency and responsiveness.
Added sidebar
Connected sidebar with react router
Added topbar
Added icons and redesigned given designs a little
Implemented portfolio view
Implemented Send and Receive views
Cleanup 'old' classname names and component names (=sendModal)
Render the topbar title based on current view