Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shakedex: query finalize tx when not found in db #333

Merged
merged 3 commits into from
Apr 18, 2021
Merged

Conversation

chikeichan
Copy link
Contributor

@chikeichan chikeichan commented Apr 16, 2021

This fixes an issue where if user finalize an exchange transfer in my domain instead of exchange, bob will look for the the finalize coin from the full node.

TODO:

  • write exchagne finalize to exchange db even when user is finalizing it from "My Domain" view

@chikeichan
Copy link
Contributor Author

Now shakedex service always query finalize tx by transfer hash + transfer name. Less dependent on what's written to the db.

@chikeichan chikeichan merged commit 24a39ff into master Apr 18, 2021
@chikeichan chikeichan deleted the query-finalize branch June 20, 2021 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant