Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by "hsd v3.0.0 staging" I mean the master branch of hsd plus this PR still in review: handshake-org/hsd#643
TODO:
Note now the "export log" function will only export current file (see bcoin-org/blgr#8) I think this is probably fine, if a developer really needs all the user's backlogs, they can direct that user to the data directory and zip all the debug files.
Benchmark testing method: I start a built Bob package from scratch and let it sync to height 80,000. Then I use this script to parse the log file(s). The script is ready for the new logger update which rotates files and there might be multiple files in the
hsd_data
directory. hsd chain module runs an internal benchmark test on every single block and prints the result to the debug log, so the script just totals these up. The "block time" therefore should be independent of network conditions since at this point the block has already been downloaded, its just the processing time. The "total time" is the user-experienced total run time to height 80,000 which may be affected by slow peers or bad network conditions, and should not be considered an accurate comparison between trials. It's just included here for completeness.OSX 10.14.6 (x86_64):
OSX 11.5.2 (arm64 -- although electron says it built for x64)
Windows 10 (x86_64):
Ubuntu 20.04 (x86_64):