-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote RPC: enable https #424
Conversation
- prohibit remote over http - remove network switcher: use wallet's network property - autofill port based on network - set default values as actual values instead of placeholders
Fun fact about this: since all the parameters are set with network defaults, if the user opens the modal and paste in the Bob Wallet API key and hits save, It will actually test connect to the internal full node, see the connection is valid and then proceed with remote RPC mode, which means shutting the internal node down! Resulting in a no connection error. |
Tried this and the HTTP part works (and Bob passes the RPC test), but websocket says 404 with this nginx config:
Start hsd with: hsd --network regtest --no-dns --no-wallet --http-host 0.0.0.0 --api-key apikeyhere nginx config:
Will get back to this later, leaving the config and error here. |
Closes #411
Reviewers can test by opening Bob in dev mode in REGTEST and configuring my hosted regtest node as the remote:
protocol:
https
host:
hns-contributor.dev
path:
Network Type:
Regtest
port:
14037
API key:
hellogoodbye-whatsmyname-123
There is one stupid hack here because in hsd
WalletNode
has no option forpath
so ifpathname
is set by user, we have to assemble a URL and pass that as thenodeURL
option toWalletNode
🤷♂️TODO:
LONG-TERM TODO: Allow self-signed cert pinning so remote rpc can connect over https without legacy CA