Allow unencrypted wallets #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Had to change a bit of |
rithvikvibhu
force-pushed
the
primary-wallet
branch
from
d0cb06b
to
e54b485
Compare
rithvikvibhu
added
the
needs translation
|
I tested following steps with this PR (on regtest): |
Falci
pushed a commit
to Falci/bob-wallet
that referenced
this pull request
Jun 22, 2022
While creating new wallet, encrypt unencrypted wallets (like `primary`) if they are not yet encrypted.
rithvikvibhu
removed
the
needs translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #438, closes #245.
When creating a new wallet, if a wallet with the same name already exists and is not encrypted (like the default
primarywallet), then the flow continues and encrypts it.Also, since the primary wallet cannot be deleted, it's handled in Settings.
Note: Untested with Ledger (watchOnly wallets), but it should work. Probably. Mostly.
i18n
2 strings added and need translations: