Minor table layout fix for "Your bids" section #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise a user may see "BIDDING NOW (1 BID(" (truncated) instead of "BIDDING NOW (1 BID(S))". See attached screenshots.
Just made it consistent with watching.scss ("Watching" section"):
- https://github.com/kyokan/bob-wallet/blob/03c8162a70cfc334c646b91fef9a899dd16d6038/app/pages/Watching/watching.scss#L144-L146
- https://github.com/kyokan/bob-wallet/blob/03c8162a70cfc334c646b91fef9a899dd16d6038/app/pages/Watching/watching.scss#L173-L175
Not sure why this was changed in b830e96.
|
Thanks for the PR @handshake-enthusiast! We need a more responsive table that doesn't depend on fixed widths. Until then, this should do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise a user may see "BIDDING NOW (1 BID(" (truncated) instead of "BIDDING NOW (1 BID(S))". See attached screenshots.
Just made it consistent with watching.scss ("Watching" section"):
bob-wallet/app/pages/Watching/watching.scss
Lines 144 to 146 in 03c8162
bob-wallet/app/pages/Watching/watching.scss
Lines 173 to 175 in 03c8162
Not sure why this was changed in b830e96.
Your Bids – Before
Your Bids – After
Watching