Update Rust crate sqlx to 0.8.1 [SECURITY] #145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.8.0
->0.8.1
GitHub Vulnerability Alerts
GHSA-xmrp-424f-vfpx
The following presentation at this year's DEF CON was brought to our attention on the SQLx Discord:
Essentially, encoding a value larger than 4GiB can cause the length prefix in the protocol to overflow,
causing the server to interpret the rest of the string as binary protocol commands or other data.
It appears SQLx does perform truncating casts in a way that could be problematic,
for example: https://github.com/launchbadge/sqlx/blob/6f2905695b9606b5f51b40ce10af63ac9e696bb8/sqlx-postgres/src/arguments.rs#L163
This code has existed essentially since the beginning,
so it is reasonable to assume that all published versions
<= 0.8.0
are affected.Mitigation
As always, you should make sure your application is validating untrustworthy user input.
Reject any input over 4 GiB, or any input that could encode to a string longer than 4 GiB.
Dynamically built queries are also potentially problematic if it pushes the message size over this 4 GiB bound.
Encode::size_hint()
can be used for sanity checks, but do not assume that the size returned is accurate.
For example, the
Json<T>
andText<T>
adapters have no reasonable way to predict or estimate the final encoded size,so they just return
size_of::<T>()
instead.For web application backends, consider adding some middleware that limits the size of request bodies by default.
Resolution
Work has started on a branch to add
#[deny]
directives for the following Clippy lints:cast_possible_truncation
cast_possible_wrap
cast_sign_loss
and to manually audit the code that they flag.
A fix is expected to be included in the
0.8.1
release (still WIP as of writing).Release Notes
launchbadge/sqlx (sqlx)
v0.8.1
Compare Source
16 pull requests were merged this release cycle.
This release contains a fix for RUSTSEC-2024-0363.
Postgres users are advised to upgrade ASAP as a possible exploit has been demonstrated:
#3440 (comment)
MySQL and SQLite do not appear to be exploitable, but upgrading is recommended nonetheless.
Added
MySqlConnectOptions::no_engine_substitution()
[[@kolinfluence]]MySqlConnectOptions::no_engine_subsitution()
(oops) in favor of the correctly spelled version.Changed
spec_error
module [[@abonander]]Use at your own risk.
libsqlite3-sys=0.30.1
to support sqlite 3.46 [[@CommanderStorm]]ring
(the existing implementation),and
aws-lc-rs
which has optional FIPS certification.runtime-tokio-rustls
,runtime-async-std-rustls
,tls-rustls
)enable the
ring
provider of RusTLS to match the existing behavior so this should not be a breaking change.tls-rustls-aws-lc-rs
feature to use theaws-lc-rs
provider.runtime-tokio-rustls
orruntime-async-std-rustls
,this will necessitate switching to the appropriate non-legacy runtime feature:
runtime-tokio
orruntime-async-std
Fixed
sqlx::Type
[[@alu]]node12
inSQLx
action [[@hamirmahal]]v0.18.1
to avoid yankedv0.14.3
[[@CommanderStorm]]Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.