Remove Collect + Sized on Rootable::Root type.
#102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are using `Gc` pointers for `DynamicRootSet` again, we need to relax the way the `Rootable` macro works so that it can work for `Gc<dyn Trait>` and `Gc` pointers which have been cast to other types.
kyren
commented
Jun 27, 2024
Comment on lines
-459
to
-461
| let arena1: Arena<Rootable![DynamicRootSet<'_>]> = Arena::new(|mc| DynamicRootSet::new(mc)); | ||
|
|
||
| let arena2: Arena<Rootable![DynamicRootSet<'_>]> = Arena::new(|mc| DynamicRootSet::new(mc)); |
There was a problem hiding this comment.
One thing I noticed here is that let arena: Arena<Rootable![MyRoot<'_>]> = Arena::new(|mc| ...); no longer works, but let arena = Arena::<Rootable![MyRoot<'_>]>::new(|mc| ...); does, and I have no idea why.
It's a very minor paper cut, but it'd be nice not to break it.
|
Fixing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are using
Gcpointers forDynamicRootSetagain, we need to relax the way theRootablemacro works so that it can work forGc<dyn Trait>andGcpointers which have been cast to other types.This is a breaking change (ofc), but hopefully it should not cause too much churn?
We could add a trait alias for
Sized + CollectRoot types to make things much easier, but I think the only way to have an actually helpful trait alias is to use the very recently stable associated type bounds.I think it's probably just not a big deal unless you do deep tricks with
Rootable(likepiccolo'sAny).This also removes the
'staticbound onRootablebecause absolutely nothing was using it (piccolodoes, but it can add it itself).