Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add order by support in aggregate functions argument scope. #780

Closed
igalklebanov opened this issue Nov 24, 2023 · 1 comment
Closed

Add order by support in aggregate functions argument scope. #780

igalklebanov opened this issue Nov 24, 2023 · 1 comment
Labels
api Related to library's API enhancement New feature or request mysql Related to MySQL oracle Related to Oracle postgres Related to PostgreSQL sqlite Related to sqlite

Comments

@igalklebanov
Copy link
Member

igalklebanov commented Nov 24, 2023 •
edited
Loading

Hey 👋

Following #779, we might want to allow chaining .orderBy where .distinct is invocable in eb.fn.agg.

Example aggregate functions where order by can be used inside the argument scope:
@igalklebanov igalklebanov added enhancement New feature or request mysql Related to MySQL sqlite Related to sqlite postgres Related to PostgreSQL api Related to library's API oracle Related to Oracle labels Nov 24, 2023
ivashog pushed a commit to ivashog/kysely that referenced this issue Mar 7, 2024
feat(operation-node): add order by ro aggregate function node
2daec93 
kysely-org#780
@ivashog ivashog mentioned this issue Mar 7, 2024
Merged
ivashog pushed a commit to ivashog/kysely that referenced this issue Mar 7, 2024
feat(query-compiler): add order by aggregate function query compiler
ab69143 
kysely-org#780
ivashog pushed a commit to ivashog/kysely that referenced this issue Mar 7, 2024
feat(operation-node): add order by to aggregate function node transfo…
f618df9 
…rmer

kysely-org#780
ivashog pushed a commit to ivashog/kysely that referenced this issue Mar 7, 2024
feat(query-builder): add orderBy method to aggregate function builder
bf05295 
kysely-org#780
ivashog pushed a commit to ivashog/kysely that referenced this issue Mar 7, 2024
test(node): add aggregate function orderBy clause node platform test
848ff97 
kysely-org#780
ivashog pushed a commit to ivashog/kysely that referenced this issue Mar 7, 2024
test(typings): add aggregate function orderBy clause typings test
ed959aa 
kysely-org#780
ivashog pushed a commit to ivashog/kysely that referenced this issue Mar 7, 2024
refactor: fix esm imports in changed files
af31386 
kysely-org#780
ivashog pushed a commit to ivashog/kysely that referenced this issue Mar 12, 2024
test(node): add separate test for order-sensitive aggregate functions…
9c83da6 
… including mysql and sqlite

kysely-org#780
ivashog pushed a commit to ivashog/kysely that referenced this issue May 3, 2024
test(typings): removed unnecessary typings test
d476c00 
kysely-org#780
@trompx
Copy link

trompx commented May 28, 2024

Hi @igalklebanov,
Had just the need for that feature. Any idea if this will be merged soon?

igalklebanov pushed a commit to ivashog/kysely that referenced this issue Jan 9, 2025
@igalklebanov
test(node): add aggregate function orderBy clause node platform test
7a27692 
kysely-org#780
igalklebanov pushed a commit to ivashog/kysely that referenced this issue Jan 9, 2025
@igalklebanov
test(typings): add aggregate function orderBy clause typings test
395b8a0 
kysely-org#780
igalklebanov pushed a commit to ivashog/kysely that referenced this issue Jan 9, 2025
@igalklebanov
test(node): add separate test for order-sensitive aggregate functions…
1c51617 
… including mysql and sqlite

kysely-org#780
igalklebanov pushed a commit to ivashog/kysely that referenced this issue Jan 9, 2025
@igalklebanov
test(typings): removed unnecessary typings test
d310d17 
kysely-org#780
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Related to library's API enhancement New feature or request mysql Related to MySQL oracle Related to Oracle postgres Related to PostgreSQL sqlite Related to sqlite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trompx @igalklebanov