Speedup types with huge databases. Fixes #867 #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
koskimas
force-pushed
the
speedup-types-with-huge-db
branch
from
4e6c35e to
dd1c732
Compare
koskimas
added
breaking change
igalklebanov
approved these changes
Jul 16, 2024
Do you mean the |
koskimas
force-pushed
the
speedup-types-with-huge-db
branch
from
dd1c732 to
cf5ef41
Compare
Come to think of it, we don't need to. |
koskimas
added a commit
that referenced
this pull request
Jul 19, 2024
igalklebanov
pushed a commit
that referenced
this pull request
Aug 25, 2024
igalklebanov
pushed a commit
that referenced
this pull request
Aug 25, 2024
igalklebanov
pushed a commit
that referenced
this pull request
Oct 3, 2024
igalklebanov
pushed a commit
that referenced
this pull request
Oct 3, 2024
igalklebanov
pushed a commit
to igalklebanov/kysely
that referenced
this pull request
Oct 4, 2024
igalklebanov
pushed a commit
that referenced
this pull request
Oct 12, 2024
igalklebanov
pushed a commit
that referenced
this pull request
Oct 19, 2024
igalklebanov
pushed a commit
that referenced
this pull request
Oct 24, 2024
igalklebanov
pushed a commit
that referenced
this pull request
Oct 24, 2024
igalklebanov
pushed a commit
that referenced
this pull request
Oct 27, 2024
igalklebanov
pushed a commit
that referenced
this pull request
Nov 2, 2024
igalklebanov
pushed a commit
that referenced
this pull request
Nov 24, 2024
igalklebanov
pushed a commit
that referenced
this pull request
Dec 1, 2024
igalklebanov
pushed a commit
that referenced
this pull request
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up type checks with huge database interfaces.
The added type test case took 12 seconds to check before the fixes and about 0.4 seconds after the fixes.
Once again, I have no idea why things got faster, but it's related to function overloads. Squashing all overloads of
selectFrom,updateTable,mergeIntoanddeleteFrominto a single signature fixes the perf issues 🤷This is a slightly breaking change. It breaks some generics use cases, but those were pretty much unusable already anyways.