Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add reusable helpers recipe and implement missing expression features #1085

Merged
merged 2 commits into from
Jul 22, 2024
Merged

add reusable helpers recipe and implement missing expression features #1085

merged 2 commits into from
Jul 22, 2024

Conversation

koskimas
Copy link
Member

Add a new recipe about creating reusable helpers.

This PR also implements some obvious things I discovered while implementing a bunch of different kinds of helper functions.

This is just a first draft and any input is welcome.

@koskimas koskimas requested a review from igalklebanov July 21, 2024 13:12
@vercel Vercel
Copy link

vercel bot commented Jul 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 6:36am

@koskimas koskimas force-pushed the add-reusable-helpers-recipe branch from 8acbd8e to 74a6b7c Compare July 21, 2024 13:14
@koskimas koskimas force-pushed the add-reusable-helpers-recipe branch from 74a6b7c to 2369295 Compare July 21, 2024 13:17
@koskimas koskimas force-pushed the add-reusable-helpers-recipe branch from 1cf8856 to 2369295 Compare July 21, 2024 13:23
@koskimas
Copy link
Member Author

koskimas commented Jul 21, 2024 •
edited
Loading

I don't understand why CI is failing. It's suddenly not finding mocha or playwright. Probably all executables are suddenly not found. @igalklebanov Any ideas? I tried disabling the npm cache but it didn't help.

edit:

Ok, wtf

Run npm ci
npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error   <https://github.com/npm/cli/issues>
npm error A complete log of this run can be found in: /home/runner/.npm/_logs/202[4](https://github.com/kysely-org/kysely/actions/runs/10028711599/job/27715968099?pr=1085#step:4:5)-07-21T13_24_03_421Z-debug-0.log

edit2:

It was an npm fuckup npm/cli#7657. Fixed by forcing an older node version in CI.

@koskimas koskimas force-pushed the add-reusable-helpers-recipe branch from 667253f to c49bfca Compare July 21, 2024 13:33
@igalklebanov
Copy link
Member

@koskimas first CrowdStrike killing many services, now this. 😨

igalklebanov
igalklebanov approved these changes Jul 21, 2024
View reviewed changes
Copy link
Member

@igalklebanov igalklebanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Love the new $asScalar thing.

@koskimas koskimas force-pushed the add-reusable-helpers-recipe branch from 2d1328c to 09da2ba Compare July 22, 2024 06:34
@koskimas koskimas force-pushed the add-reusable-helpers-recipe branch from 09da2ba to 64899e1 Compare July 22, 2024 06:36
@koskimas koskimas merged commit 01226a4 into v0.28 Jul 22, 2024
12 checks passed
@koskimas koskimas deleted the add-reusable-helpers-recipe branch July 22, 2024 12:18
@igalklebanov igalklebanov added the documentation Improvements or additions to documentation label Jul 22, 2024
@igalklebanov igalklebanov added enhancement New feature or request api Related to library's API labels Jul 22, 2024
igalklebanov pushed a commit that referenced this pull request Aug 25, 2024
@koskimas @igalklebanov
add reusable helpers recipe and implement missing expression features (…
c522df5 
…#1085)

* add reusable helpers recipe and implement missing expression features

* force node 22.4.1 in CI because of an npm bug
igalklebanov pushed a commit that referenced this pull request Aug 25, 2024
@koskimas @igalklebanov
add reusable helpers recipe and implement missing expression features (…
6f0bc77 
…#1085)

* add reusable helpers recipe and implement missing expression features

* force node 22.4.1 in CI because of an npm bug
igalklebanov pushed a commit that referenced this pull request Oct 3, 2024
@koskimas @igalklebanov
add reusable helpers recipe and implement missing expression features (…
e794923 
…#1085)

* add reusable helpers recipe and implement missing expression features

* force node 22.4.1 in CI because of an npm bug
igalklebanov pushed a commit that referenced this pull request Oct 3, 2024
@koskimas @igalklebanov
add reusable helpers recipe and implement missing expression features (…
fb74dec 
…#1085)

* add reusable helpers recipe and implement missing expression features

* force node 22.4.1 in CI because of an npm bug
igalklebanov pushed a commit to igalklebanov/kysely that referenced this pull request Oct 4, 2024
@koskimas @igalklebanov
add reusable helpers recipe and implement missing expression features (…
5a4d2d1 
…kysely-org#1085)

* add reusable helpers recipe and implement missing expression features

* force node 22.4.1 in CI because of an npm bug
igalklebanov pushed a commit that referenced this pull request Oct 12, 2024
@koskimas @igalklebanov
add reusable helpers recipe and implement missing expression features (…
b641099 
…#1085)

* add reusable helpers recipe and implement missing expression features

* force node 22.4.1 in CI because of an npm bug
igalklebanov pushed a commit that referenced this pull request Oct 19, 2024
@koskimas @igalklebanov
add reusable helpers recipe and implement missing expression features (…
0bc588f 
…#1085)

* add reusable helpers recipe and implement missing expression features

* force node 22.4.1 in CI because of an npm bug
igalklebanov pushed a commit that referenced this pull request Oct 24, 2024
@koskimas @igalklebanov
add reusable helpers recipe and implement missing expression features (…
c72db46 
…#1085)

* add reusable helpers recipe and implement missing expression features

* force node 22.4.1 in CI because of an npm bug
igalklebanov pushed a commit that referenced this pull request Oct 24, 2024
@koskimas @igalklebanov
add reusable helpers recipe and implement missing expression features (…
72bd054 
…#1085)

* add reusable helpers recipe and implement missing expression features

* force node 22.4.1 in CI because of an npm bug
igalklebanov pushed a commit that referenced this pull request Oct 27, 2024
@koskimas @igalklebanov
add reusable helpers recipe and implement missing expression features (…
7311713 
…#1085)

* add reusable helpers recipe and implement missing expression features

* force node 22.4.1 in CI because of an npm bug
igalklebanov pushed a commit that referenced this pull request Nov 2, 2024
@koskimas @igalklebanov
add reusable helpers recipe and implement missing expression features (…
172d58a 
…#1085)

* add reusable helpers recipe and implement missing expression features

* force node 22.4.1 in CI because of an npm bug
igalklebanov pushed a commit that referenced this pull request Nov 24, 2024
@koskimas @igalklebanov
add reusable helpers recipe and implement missing expression features (…
5ba9f2d 
…#1085)

* add reusable helpers recipe and implement missing expression features

* force node 22.4.1 in CI because of an npm bug
igalklebanov pushed a commit that referenced this pull request Dec 1, 2024
@koskimas @igalklebanov
add reusable helpers recipe and implement missing expression features (…
537328e 
…#1085)

* add reusable helpers recipe and implement missing expression features

* force node 22.4.1 in CI because of an npm bug
igalklebanov pushed a commit that referenced this pull request Dec 8, 2024
@koskimas @igalklebanov
add reusable helpers recipe and implement missing expression features (…
c0cf9f1 
…#1085)

* add reusable helpers recipe and implement missing expression features

* force node 22.4.1 in CI because of an npm bug
igalklebanov pushed a commit that referenced this pull request Jan 5, 2025
@koskimas @igalklebanov
add reusable helpers recipe and implement missing expression features (…
c4bbed8 
…#1085)

* add reusable helpers recipe and implement missing expression features

* force node 22.4.1 in CI because of an npm bug
igalklebanov pushed a commit that referenced this pull request Jan 9, 2025
@koskimas @igalklebanov
add reusable helpers recipe and implement missing expression features (…
88dc5b1 
…#1085)

* add reusable helpers recipe and implement missing expression features

* force node 22.4.1 in CI because of an npm bug
igalklebanov pushed a commit that referenced this pull request Jan 11, 2025
@koskimas @igalklebanov
add reusable helpers recipe and implement missing expression features (…
0bbe9c1 
…#1085)

* add reusable helpers recipe and implement missing expression features

* force node 22.4.1 in CI because of an npm bug
igalklebanov pushed a commit that referenced this pull request Jan 12, 2025
@koskimas @igalklebanov
add reusable helpers recipe and implement missing expression features (…
9e01281 
…#1085)

* add reusable helpers recipe and implement missing expression features

* force node 22.4.1 in CI because of an npm bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalklebanov igalklebanov igalklebanov approved these changes

Assignees
No one assigned
Labels
api Related to library's API documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koskimas @igalklebanov